tests: add cookies keyword and features #10713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fails with `--disable-cookies`. Closes curl#10713
MarcelRaad
force-pushed
the
test420_disable-cookies
branch
from
356ce85 to
fa04e48
Compare
|
You need to add |
|
Right, thanks! I'll do that in a separate commit for all cookie tests. AFAICS, all of them are missing the feature. I wonder why I didn't do that earlier and still disable them via the label. 😕 |
These tests don't work with `--disable-cookies`. Closes curl#10713
MarcelRaad
changed the title
|
Pushed another commit to add |
I presume we started out using the label approach before we made it a testable feature. |
bagder
approved these changes
Mar 9, 2023
MarcelRaad
added a commit
that referenced
this pull request
Mar 9, 2023
These tests don't work with `--disable-cookies`. Closes #10713
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
It fails with `--disable-cookies`. Closes curl#10713
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
These tests don't work with `--disable-cookies`. Closes curl#10713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fails with
--disable-cookies.As seen in the autobuilds: https://curl.se/dev/log.cgi?id=20230308051817-71055#prob1