build: fix stdint/inttypes detection with non-autotools #10745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delete unused `CURL_PULL_STDINT_H`. - Delete unused `CURL_PULL_INTTYPES_H`. - Delete duplicate detection for `HAVE_STDINT_H`. Present since the initial CMake commit: 4c5307b Closes curl#10745
vszakats
force-pushed
the
cmake-del-unused
branch
from
8219a9a to
031868e
Compare
vszakats
changed the title
vszakats
changed the title
vszakats
changed the title
bagder
approved these changes
Mar 13, 2023
vszakats
added a commit
that referenced
this pull request
Mar 14, 2023
- add QUIC/ngtcp2 detection in CMake with wolfSSL. Because wolfSSL uses zlib if available, move compression detection before TLS detection. (OpenSSL might also need this in the future.) - wolfSSL 5.5.0 started using C99 types in its `quic.h` header, but it doesn't #include the necessary C99 header itself, breaking builds (unless another dependency pulled it by chance.) Add local workaround for it. For this to work with all build tools, we had to fix our header detection first. Ref: #10745 Ref: curl/curl-for-win@6ad5f6e Closes #10739
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Fix `stdint.h` and `inttypes.h` detection with non-autotools builds on Windows. (autotools already auto-detected them accurately.) `lib/config-win32.h` builds (e.g. `Makefile.mk`): - set `HAVE_STDINT_H` where supported. - set `HAVE_INTTYPES_H` for MinGW. CMake: - auto-detect them on Windows. (They were both force-disabled.) - delete unused `CURL_PULL_STDINT_H`. - delete unused `CURL_PULL_INTTYPES_H`. - stop detecting `HAVE_STDINT_H` twice. Present since the initial CMake commit: 4c5307b curl doesn't use these C99 headers, we need them now to workaround broken wolfSSL builds. Ref: curl#10739 Once that clears up, we can delete these detections and macros (unless we want to keep them for future us.) Reviewed-by: Daniel Stenberg Closes curl#10745
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- add QUIC/ngtcp2 detection in CMake with wolfSSL. Because wolfSSL uses zlib if available, move compression detection before TLS detection. (OpenSSL might also need this in the future.) - wolfSSL 5.5.0 started using C99 types in its `quic.h` header, but it doesn't #include the necessary C99 header itself, breaking builds (unless another dependency pulled it by chance.) Add local workaround for it. For this to work with all build tools, we had to fix our header detection first. Ref: curl#10745 Ref: curl/curl-for-win@6ad5f6e Closes curl#10739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
stdint.handinttypes.hdetection with non-autotools buildson Windows. (autotools already auto-detected them correctly.)
lib/config-win32.hbuilds (e.g.Makefile.mk):HAVE_STDINT_Hwhere supported.HAVE_INTTYPES_Hfor MinGW.CMake:
CURL_PULL_STDINT_H.CURL_PULL_INTTYPES_H.HAVE_STDINT_Htwice.Present since the initial CMake commit: 4c5307b
curl doesn't use these C99 headers, we need them now to
workaround broken wolfSSL builds. Ref: #10739
Once that clears up, we can delete these detections and macros (unless we want to keep them for
future us.)
Closes #10745