Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: run all linux test jobs with valgrind #10798

Closed
wants to merge 2 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Mar 20, 2023

No description provided.

@bagder bagder added the CI Continuous Integration label Mar 20, 2023
@bagder
Copy link
Member Author

bagder commented Mar 20, 2023

The many test failures here show exactly the ones that we didn't see in time for the 8.0.0 release... I will rebase this on top of master and verify that no errors remain.

@bagder bagder force-pushed the bagder/gha-valgrind branch from d167654 to 949e388 Compare March 20, 2023 16:00
@bagder
Copy link
Member Author

bagder commented Mar 20, 2023

New finding. These six tests fail with valgrind in hyper builds: 1069 1072 1073 1500 1539 1554

@bagder
Copy link
Member Author

bagder commented Mar 21, 2023

The clang builds and the NSS build all show "unhandled dwarf2 abbrev form code" errors so I need to disable valgrind for those builds.

@MarcelRaad
Copy link
Member

According to e.g. https://bugs.kde.org/show_bug.cgi?id=457412, another solution would be to force DWARF v4 by passing -gdwarf-4 to the compiler.

@thesamesam
Copy link
Contributor

According to e.g. bugs.kde.org/show_bug.cgi?id=457412, another solution would be to force DWARF v4 by passing -gdwarf-4 to the compiler.

or do Valgrind builds on a distro with >= 3.20.0. I haven't looked yet at what the distribution of compiler versions and such is but it might be useful aside from Valgrind.

@bagder bagder force-pushed the bagder/gha-valgrind branch from e82292c to 9a45db7 Compare March 22, 2023 09:11
@bagder
Copy link
Member Author

bagder commented Mar 22, 2023

I think it is fine to run it on only the gcc builds for now. What I cannot explain though is how the hyper errors vanished in a rerun...

@bagder bagder closed this in caf92a5 Mar 22, 2023
bagder added a commit that referenced this pull request Mar 22, 2023
@bagder bagder deleted the bagder/gha-valgrind branch March 22, 2023 12:52
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Development

Successfully merging this pull request may close these issues.

3 participants