tool_writeout: add URL component variables #10853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
added
cmdline tool
next-feature-window
![github-code-scanning[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bagder
force-pushed
the
bagder/writeout-url-parts
branch
3 times, most recently
from
a79ff1d
to
43e2f54
Compare
bagder
removed
the
next-feature-window
rybak
reviewed
Mar 30, 2023
Output specific components from the used URL. The following variables are added for this purpose: url.scheme, url.user, url.password, url.options, url.host, url.port, url.path, url.query, url.fragment, url.zoneid Add the following for outputting parts of the "effective URL": urle.scheme, urle.user, urle.password, urle.options, urle.host, urle.port, urle.path, urle.query, urle.fragment, urle.zoneid Added test 423 and 424 to verify. Closes #10853
bagder
force-pushed
the
bagder/writeout-url-parts
branch
from
ad247e2
to
4fd4228
Compare
jay
reviewed
Apr 1, 2023
| .TP | ||
| .B urle.zoneid | ||
| The zoneid part of the effective (last) URL that was fetched. (Added in 8.1.0) | ||
| .TP |
There was a problem hiding this comment.
This could all be combined in .B url and .B url_effective (imo makes more sense than urle) to say something like
.B url
The URL that was fetched. (Added in 7.75.0)
Individual parts of the URL can written using format `url.<part>`. The
part names are: are fragment, host, options, password, path, port,
query, scheme, user, and zoneid. (Added in 8.1.0)
There was a problem hiding this comment.
It could be written like that but would make them much harder to find and they can't be searchable in their full names. I prefer listing all names the same way.
I went with "urle" instead of "url_effective" simply because the names becomes unwieldy long otherwise. Like url_effective.fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Output specific components from the used URL. The following
-wvariables are added for this purpose:url.scheme, url.user, url.password, url.options, url.host, url.port, url.path, url.query, url.fragment, url.zoneid
and for getting the components out of the "effective URL":
urle.scheme, urle.user, urle.password, urle.options, urle.host, urle.port, urle.path, urle.query, urle.fragment, urle.zoneid
Added test 423 and 424 to verify.