New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rustls-ffi 0.10.0 #10865
base: master
Are you sure you want to change the base?
Update to rustls-ffi 0.10.0 #10865
Conversation
Interesting. The test failure is under address_sanitizer, but appears to be a failed assertion indicating that a connection was reused more than expected (one connect vs two).
|
@icing I see you've been working on the pytests. Any idea why this would fail just on address_sanitizer? |
First guess: the curl client becomes so slow, that apache answers the requests before the first connection runs out of space. So, a second one is never needed. Hmm...we could change the assert to Added #10870 for exactly this. |
Closed by mistake, sorry |
This brings in version 0.21.0 of the upstream rustls implementation, which notable includes support for IP address certificates. This allows enabling many of the unittests that relied on IP address certificates to communicate with localhost.
This tests are still fail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing
Yep, have been meaning to look into this more. Apologies for the delay. |
This brings in version 0.21.0 of the upstream rustls implementation, which notable includes support for IP address certificates. This allows enabling many of the unittests that relied on IP address certificates to communicate with localhost.