New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: Don't send header fields prohibited by HTTP/2 spec #1092

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@tatsuhiro-t
Contributor

tatsuhiro-t commented Oct 30, 2016

Previously, we just ignored "Connection" header field. But HTTP/2
specification actually prohibits few more header fields. This commit
ignores all of them so that we don't send these bad header fields.

http2: Don't send header fields prohibited by HTTP/2 spec
Previously, we just ignored "Connection" header field.  But HTTP/2
specification actually prohibits few more header fields.  This commit
ignores all of them so that we don't send these bad header fields.
@mention-bot

This comment has been minimized.

mention-bot commented Oct 30, 2016

@tatsuhiro-t, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Andersbakken, @jay and @bagder to be potential reviewers.

@bagder bagder added the HTTP/2 label Oct 30, 2016

@jay

trailers can be anywhere so I think we will have to account for this, for example
TE: trailers, deflate
TE: deflate, trailers;qabc

@tatsuhiro-t

This comment has been minimized.

Contributor

tatsuhiro-t commented Oct 31, 2016

Good point.. Yes, we need to parse it. Does curl have convenient function to parse this comma separated list header fields?

@jay

This comment has been minimized.

Member

jay commented Nov 3, 2016

Does curl have convenient function to parse this comma separated list header fields?

hm offhand I can't think of one. There's always strtok_r. Also I don't think we have to check for the semi-colon in trailers if I'm reading this right:

       TE        = "TE" ":" #( t-codings )
       t-codings = "trailers" | ( transfer-extension [ accept-params ] )
       transfer-coding         = "chunked" | transfer-extension
       transfer-extension      = token *( ";" parameter )
@tatsuhiro-t

This comment has been minimized.

Contributor

tatsuhiro-t commented Nov 6, 2016

Thank you. I ended up not to use strtok_r since it requires NULL-terminated string, and it replaces delimiter with NUL byte. Instead, I added hand crafted "trailers" detection code.
Conflict has been resolved as well.

@jay jay closed this in 0269f64 Nov 7, 2016

@jay

This comment has been minimized.

Member

jay commented Nov 7, 2016

I ended up not to use strtok_r since it requires NULL-terminated string, and it replaces delimiter with NUL byte. Instead, I added hand crafted "trailers" detection code.

Oops I forgot about that. Your changes just landed. I made a few corrections:

  • Typo. Searching for tab had used 't' instead of '\t'
  • Unnecessary goto. We discourage goto when not necessary so I redid the logic.
  • enum names too generic. (For example IGNORE is defined to 0 somewhere in my includes so I prefixed them with HEADERINST_)
  • Unreachable code. Some compilers may warn that since the for(;;) is never exited the return after that block will never be hit, so I removed it.
  • Minor style changes

Thanks!

@tatsuhiro-t

This comment has been minimized.

Contributor

tatsuhiro-t commented Nov 7, 2016

The commit looks good. Thank you for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment