cookie: clarify that init with data set to NULL reads no file #10930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/cookie-data-null
branch
from
5be36d7 to
3ce436e
Compare
kvarec
added a commit
to kvarec/curl_fixes
that referenced
this pull request
Apr 12, 2023
Conflicts with fix curl#10930
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
... and make Curl_cookie_add() require 'data' being set proper with an assert. The function has not worked with a NULL data for quite some time so this just corrects the code and comment. This is a different take than the proposed fixed in curl#10927 Reported-by: Kvarec Lezki Ref: curl#10929 Closes curl#10930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and make Curl_cookie_add() require 'data' being set proper with an assert.
The function has not worked with a NULL data for quite some time so this just corrects the code and comment.
This is a different take than the proposed fixed in #10927
Reported-by: Kvarec Lezki in #10929