HTTTP/3 all backends, check stream_ctx more thoroughly #10951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
icing
commented
Apr 13, 2023
icing
commented
- callbacks and filter methods might be invoked at unexpected times, e.g. when the transfer's stream_ctx has not been initialized yet or, more likely, has already been taken down.
- check for existance of stream_ctx in such places and return an error or silently succeed the call.
- callbacks and filter methods might be invoked at unexpected times, e.g. when the transfer's stream_ctx has not been initialized yet or, more likely, has already been taken down. - check for existance of stream_ctx in such places and return an error or silently succeed the call.
pheiduck
reviewed
Apr 13, 2023
| @@ -344,6 +344,8 @@ static CURLcode write_resp_raw(struct Curl_cfilter *cf, | |||
| ssize_t nwritten; | |||
|
|
|||
| (void)cf; | |||
| if(!stream) | |||
There was a problem hiding this comment.
Compiler complaines about: quiche_stream_iter *qiter = quiche_conn_writable(ctx->qconn);
May this will fix it?:
if(!stream) {
return FALSE;
}
There was a problem hiding this comment.
Thanks! Just pushed a fix.
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- callbacks and filter methods might be invoked at unexpected times, e.g. when the transfer's stream_ctx has not been initialized yet or, more likely, has already been taken down. - check for existance of stream_ctx in such places and return an error or silently succeed the call. Closes curl#10951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.