Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTTP/3 all backends, check stream_ctx more thoroughly #10951

Closed
wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Apr 13, 2023

  • callbacks and filter methods might be invoked at unexpected times, e.g. when the transfer's stream_ctx has not been initialized yet or, more likely, has already been taken down.
  • check for existance of stream_ctx in such places and return an error or silently succeed the call.

- callbacks and filter methods might be invoked at unexpected
  times, e.g. when the transfer's stream_ctx has not been initialized
  yet or, more likely, has already been taken down.
- check for existance of stream_ctx in such places and return
  an error or silently succeed the call.
@github-actions github-actions bot added the HTTP/3 h3 or quic related label Apr 13, 2023
@@ -344,6 +344,8 @@ static CURLcode write_resp_raw(struct Curl_cfilter *cf,
ssize_t nwritten;

(void)cf;
if(!stream)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler complaines about: quiche_stream_iter *qiter = quiche_conn_writable(ctx->qconn);

May this will fix it?:

if(!stream) {
   return FALSE;
}

Copy link
Contributor Author

@icing icing Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just pushed a fix.

@bagder
Copy link
Member

bagder commented Apr 13, 2023

Thanks!

@bagder bagder closed this in be800a6 Apr 13, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
- callbacks and filter methods might be invoked at unexpected
  times, e.g. when the transfer's stream_ctx has not been initialized
  yet or, more likely, has already been taken down.
- check for existance of stream_ctx in such places and return
  an error or silently succeed the call.

Closes curl#10951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTTP/3 h3 or quic related
Development

Successfully merging this pull request may close these issues.

None yet

3 participants