Disable socket receive buffer, unless USE_RECV_BEFORE_SEND_WORKAROUND… #10961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is in place While we would like to use this, we have stalls in parallel transfers where not all buffered data is consumed and no socket events happen.
|
Thanks. This is a difficult and time consuming area. |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- Disable socket receive buffer unless USE_RECV_BEFORE_SEND_WORKAROUND is in place. While we would like to use the receive buffer, we have stalls in parallel transfers where not all buffered data is consumed and no socket events happen. Note USE_RECV_BEFORE_SEND_WORKAROUND is a Windows sockets workaround that has been disabled by default since b4b6e4f, due to other bugs. Closes curl#10961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is in place
While we would like to use this, we have stalls in parallel transfers where not all buffered data is consumed and no socket events happen.