autotools: sync up clang picky warnings with cmake #10974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
MarcelRaad
reviewed
Apr 16, 2023
m4/curl-compilers.m4
Outdated
| CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [shadow]) | ||
| CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [unused]) | ||
| CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [no-multichar]) | ||
| CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [no-system-headers]) |
There was a problem hiding this comment.
This one is actually already defined below.
There was a problem hiding this comment.
You're right, thanks for spotting them.
Bringing missing options over from CMake. Closes curl#10974
vszakats
changed the title
for failing: macOS / SecureTransport http2 (pull_request)
|
This is unrelated and happens also without this patch: |
bagder
added a commit
that referenced
this pull request
Apr 16, 2023
Ref: #10974 (comment) Reported-by: Viktor Szakats
bagder
added a commit
that referenced
this pull request
Apr 17, 2023
Ref: #10974 (comment) Reported-by: Viktor Szakats Closes #10982
MarcelRaad
approved these changes
Apr 17, 2023
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Ref: curl#10974 (comment) Reported-by: Viktor Szakats Closes curl#10982
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Bringing missing options over from CMake. Move around existing `-Wno-pointer-bool-conversion` option to come _after_ `-Wconversion`. Reviewed-by: Marcel Raad Closes curl#10974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing missing options over from CMake.
Move around existing
-Wno-pointer-bool-conversionoption to comeafter
-Wconversion.Closes #10974