Move easy_lock.h above curl_memory.h #11140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to curl#9561, move easy_lock.h above curl_memory.h to fix building against musl libc.
Contributor
|
NB, we should add a CI build on Alpine to catch this. This is easy to do Cirrus CI I know, and probably other CI platforms as well.
|
bagder
approved these changes
May 18, 2023
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
So sloppy of me to violate the clear "The last 3 #include files should be" ... 😢
Member
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Similar to curl#9561, move easy_lock.h above curl_memory.h to fix building against musl libc. Closes curl#11140
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
MUSL is another libc implementation which has its own unique issues worth testing. Ref: curl#11140 Closes curl#11178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #9561, move easy_lock.h above curl_memory.h to fix building against musl libc.