Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: remove newlines from all notef/warnf/errorf calls #11226

Closed
wants to merge 7 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 30, 2023

Make voutf() always add one.

Closes #11226

@bagder bagder force-pushed the bagder/warning-newline branch from 0763220 to 62de261 Compare May 31, 2023 06:31
@@ -1038,7 +1038,7 @@
break;

case 'v': /* --stderr */
tool_set_stderr_file(nextarg);
tool_set_stderr_file(global, nextarg);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This argument to a file access function is derived from [user input (string read by fgets)](1) and then passed to tool_set_stderr_file(filename), which calls fopen(__filename).
@bagder bagder closed this in 6d45b9c Jun 1, 2023
@bagder bagder deleted the bagder/warning-newline branch June 1, 2023 06:20
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant