Skip to content

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme} - #1137

Closed
gevaerts wants to merge 1 commit into
curl:masterfrom
gevaerts:master
Closed

gevaerts wants to merge 1 commit into
curl:masterfrom
gevaerts:master

Conversation

@gevaerts

Copy link
Copy Markdown
Contributor
Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string handling
in getinfo.c got const-ified.

@mention-bot

Copy link
Copy Markdown

@gevaerts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @philipc to be potential reviewers.

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clean and I see no problems. Ready for merge!

    Adds access to the effectively used protocol/scheme to both libcurl and
    curl, both in string and numeric (CURLPROTO_*) form.

    Note that the string form will be uppercase, as it is just the internal
    string.

    As these strings are declared internally as const, and all other strings
    returned by curl_easy_getinfo() are de-facto const as well, string handling
    in getinfo.c got const-ified.
@bagder

bagder commented Nov 24, 2016

Copy link
Copy Markdown
Member

thanks!

@lock lock Bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants