New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme} #1137

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@gevaerts
Contributor

gevaerts commented Nov 23, 2016

Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string handling
in getinfo.c got const-ified.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Nov 23, 2016

@gevaerts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @philipc to be potential reviewers.

mention-bot commented Nov 23, 2016

@gevaerts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @philipc to be potential reviewers.

@bagder

bagder approved these changes Nov 23, 2016

This looks clean and I see no problems. Ready for merge!

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
    Adds access to the effectively used protocol/scheme to both libcurl and
    curl, both in string and numeric (CURLPROTO_*) form.

    Note that the string form will be uppercase, as it is just the internal
    string.

    As these strings are declared internally as const, and all other strings
    returned by curl_easy_getinfo() are de-facto const as well, string handling
    in getinfo.c got const-ified.

@bagder bagder closed this in ba410f6 Nov 24, 2016

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Nov 24, 2016

Member

thanks!

Member

bagder commented Nov 24, 2016

thanks!

vulpine added a commit to vulpine/curl that referenced this pull request Nov 30, 2016

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string
handling in getinfo.c got const-ified.

Closes #1137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment