add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme} #1137

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@gevaerts
Contributor
Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string handling
in getinfo.c got const-ified.
@mention-bot

@gevaerts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @philipc to be potential reviewers.

@bagder
bagder approved these changes Nov 23, 2016 View changes

This looks clean and I see no problems. Ready for merge!

@gevaerts gevaerts add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
    Adds access to the effectively used protocol/scheme to both libcurl and
    curl, both in string and numeric (CURLPROTO_*) form.

    Note that the string form will be uppercase, as it is just the internal
    string.

    As these strings are declared internally as const, and all other strings
    returned by curl_easy_getinfo() are de-facto const as well, string handling
    in getinfo.c got const-ified.
d29e626
@bagder bagder added a commit that closed this pull request Nov 24, 2016
@gevaerts @bagder gevaerts + bagder add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string
handling in getinfo.c got const-ified.

Closes #1137
ba410f6
@bagder bagder closed this in ba410f6 Nov 24, 2016
@bagder
Member
bagder commented Nov 24, 2016

thanks!

@vulpine vulpine added a commit to vulpine/curl that referenced this pull request Nov 30, 2016
@gevaerts @vulpine gevaerts + vulpine add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string
handling in getinfo.c got const-ified.

Closes #1137
0d1b9d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment