Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme} #1137

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@gevaerts
Copy link
Contributor

commented Nov 23, 2016

Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string handling
in getinfo.c got const-ified.
@mention-bot

This comment has been minimized.

Copy link

commented Nov 23, 2016

@gevaerts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @philipc to be potential reviewers.

@gevaerts gevaerts force-pushed the gevaerts:master branch from 33b80b3 to c6e46f8 Nov 23, 2016

@bagder

bagder approved these changes Nov 23, 2016

Copy link
Member

left a comment

This looks clean and I see no problems. Ready for merge!

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
    Adds access to the effectively used protocol/scheme to both libcurl and
    curl, both in string and numeric (CURLPROTO_*) form.

    Note that the string form will be uppercase, as it is just the internal
    string.

    As these strings are declared internally as const, and all other strings
    returned by curl_easy_getinfo() are de-facto const as well, string handling
    in getinfo.c got const-ified.

@gevaerts gevaerts force-pushed the gevaerts:master branch from c6e46f8 to d29e626 Nov 24, 2016

@bagder bagder closed this in ba410f6 Nov 24, 2016

@bagder

This comment has been minimized.

Copy link
Member

commented Nov 24, 2016

thanks!

vulpine pushed a commit to vulpine/curl that referenced this pull request Nov 30, 2016

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string
handling in getinfo.c got const-ified.

Closes curl#1137

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.