New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Winbuild config option ENABLE_NGHTTP2 #1141

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Jan-E
Contributor

Jan-E commented Nov 25, 2016

At every new release of curl, I am editing winbuild/MakefileBuild.vc. The edits:

  1. Add nghttp2.lib to the SSL_LIBS
  2. Add /DUSE_NGHTTP2 to the SSL_CFLAGS

Of course, I'd rather change my nmake /f Makefile.vc build line. This PR adds an extra option ENABLE_NGHTTP2=yes. ENABLE_NGHTTP2 defaults to 'no' to avoid breaks in current build lines.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Nov 25, 2016

@Jan-E, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @vszakats and @BurningEnlightenment to be potential reviewers.

mention-bot commented Nov 25, 2016

@Jan-E, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @vszakats and @BurningEnlightenment to be potential reviewers.

@bagder bagder added the build label Nov 25, 2016

@bagder

bagder approved these changes Nov 25, 2016

Not a windows dude really but this looks like a sane and safe approach!

@bagder bagder closed this in 65894c9 Nov 25, 2016

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Nov 25, 2016

Member

thanks!

Member

bagder commented Nov 25, 2016

thanks!

@Jan-E Jan-E referenced this pull request Nov 25, 2016

Closed

Enable NGHTTP2 #5

vulpine added a commit to vulpine/curl that referenced this pull request Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment