Add Winbuild config option ENABLE_NGHTTP2 #1141

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Jan-E
Contributor
Jan-E commented Nov 25, 2016

At every new release of curl, I am editing winbuild/MakefileBuild.vc. The edits:

  1. Add nghttp2.lib to the SSL_LIBS
  2. Add /DUSE_NGHTTP2 to the SSL_CFLAGS

Of course, I'd rather change my nmake /f Makefile.vc build line. This PR adds an extra option ENABLE_NGHTTP2=yes. ENABLE_NGHTTP2 defaults to 'no' to avoid breaks in current build lines.

@Jan-E Jan-E Add Winbuild config option ENABLE_NGHTTP2
a3c102f
@mention-bot

@Jan-E, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @vszakats and @BurningEnlightenment to be potential reviewers.

@bagder bagder added the build label Nov 25, 2016
@bagder
bagder approved these changes Nov 25, 2016 View changes

Not a windows dude really but this looks like a sane and safe approach!

@bagder bagder added a commit that closed this pull request Nov 25, 2016
@Jan-E @bagder Jan-E + bagder winbuild: add config option ENABLE_NGHTTP2
Closes #1141
65894c9
@bagder bagder closed this in 65894c9 Nov 25, 2016
@bagder
Member
bagder commented Nov 25, 2016

thanks!

@Jan-E Jan-E referenced this pull request in winlibs/cURL Nov 25, 2016
Open

Enable NGHTTP2 #5

@vulpine vulpine added a commit to vulpine/curl that referenced this pull request Nov 30, 2016
@Jan-E @vulpine Jan-E + vulpine winbuild: add config option ENABLE_NGHTTP2
Closes #1141
67943b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment