Secure transport: fix busy loop on EOF read #11427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to busy loop. using return code used before the large refactor from 2022
bagder
changed the title
icing
approved these changes
Jul 13, 2023
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Regression since the large refactor from 2022 Closes curl#11427
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Regression since the large refactor from 2022 Closes curl#11427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if EOF happens, socket is readable, SSLHandshake calls bio_cf_in_read; which interprets nread == 0 as errSSLWouldBlock, which leads to busy loop until timeout occurs or possibly write fails.
I have tried to return success with nread being 0 but SSLHandshake returns errSecParam. Returning errSSLClosedGraceful (old return value from 55807e6#diff-016d06b58b35fe28e30d7967febf3d90524f38baf4f4c5923482a3ebde438ccfL859) leads to SSLHandshake returning errSSLClosedAbort (at least on M2 mac on Ventura); I assume the errSSLClosedNoNotify from the old comment may be returned outside of handshake, but that was not tested.