HTTP/2, treat initial SETTINGS as a WINDOW_UPDATE#11450
Closed
icing wants to merge 4 commits intocurl:masterfrom
Closed
HTTP/2, treat initial SETTINGS as a WINDOW_UPDATE#11450icing wants to merge 4 commits intocurl:masterfrom
icing wants to merge 4 commits intocurl:masterfrom
Conversation
Contributor
icing
commented
Jul 17, 2023
icing
commented
- refs HTTP/2 connection uploads stall in 8.1.0 .. 8.1.2 #11426 where spurious stalls on large POST requests are reported
- the issue seems to involve the following
- first stream on connection adds up to 64KB of POST data, which is the max default HTTP/2 stream window size transfer is set to HOLD
- initial SETTINGS from server arrive, enlarging the stream window. But no WINDOW_UPDATE is received.
- curl stalls
- the fix un-HOLDs a stream on receiving SETTINGS, not relying on a WINDOW_UPDATE from lazy servers
- refs curl#11426 where spurious stalls on large POST requests are reported - the issue seems to involve the following * first stream on connection adds up to 64KB of POST data, which is the max default HTTP/2 stream window size transfer is set to HOLD * initial SETTINGS from server arrive, enlarging the stream window. But no WINDOW_UPDATE is received. * curl stalls - the fix un-HOLDs a stream on receiving SETTINGS, not relying on a WINDOW_UPDATE from lazy servers
bagder
reviewed
Jul 17, 2023
bagder
reviewed
Jul 17, 2023
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- refs curl#11426 where spurious stalls on large POST requests are reported - the issue seems to involve the following * first stream on connection adds up to 64KB of POST data, which is the max default HTTP/2 stream window size transfer is set to HOLD * initial SETTINGS from server arrive, enlarging the stream window. But no WINDOW_UPDATE is received. * curl stalls - the fix un-HOLDs a stream on receiving SETTINGS, not relying on a WINDOW_UPDATE from lazy servers Closes curl#11450
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- refs curl#11426 where spurious stalls on large POST requests are reported - the issue seems to involve the following * first stream on connection adds up to 64KB of POST data, which is the max default HTTP/2 stream window size transfer is set to HOLD * initial SETTINGS from server arrive, enlarging the stream window. But no WINDOW_UPDATE is received. * curl stalls - the fix un-HOLDs a stream on receiving SETTINGS, not relying on a WINDOW_UPDATE from lazy servers Closes curl#11450
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.