Remove unneeded unit*_LDADD overrides in unit test Makefile.inc#11494
Closed
aloisklink wants to merge 2 commits into
Closed
Remove unneeded unit*_LDADD overrides in unit test Makefile.inc#11494aloisklink wants to merge 2 commits into
unit*_LDADD overrides in unit test Makefile.inc#11494aloisklink wants to merge 2 commits into
Conversation
These custom `unit1394_LDADD` and similar automake overrides are no longer neded. They were originally added by added by [8dac7be][] for metalink support, but are no longer after [265b14d][] removed metalink. [8dac7be]: curl@8dac7be [265b14d]: curl@265b14d
The `unit1621_LDADD` variable has the exact same value as the `LDADD` flag in `Makefile.am`, except without `@LDFLAGS@ @LIBCURL_LIBS@`. This was originally added by [98e6629][], but I can't see any reason why it exists, so we should remove it to clean things up. [98e6629]: curl@98e6629
bagder
approved these changes
Jul 21, 2023
Member
|
Thanks! |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
These custom `unit1394_LDADD` and similar automake overrides are no longer neded. They were originally added by added by [8dac7be][] for metalink support, but are no longer after [265b14d][] removed metalink. [8dac7be]: curl@8dac7be [265b14d]: curl@265b14d Closes curl#11494
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
The `unit1621_LDADD` variable has the exact same value as the `LDADD` flag in `Makefile.am`, except without `@LDFLAGS@ @LIBCURL_LIBS@`. This was originally added by [98e6629][], but I can't see any reason why it exists, so we should remove it to clean things up. [98e6629]: curl@98e6629 Closes curl#11494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was making PR #11446 and trying to build all of the unit tests in CMake, I noticed that some of the unit tests seem to have unneeded
_LDADDoverrides in thetests/unit/Makefile.incfile.For reference, the default
LDADDfor all unit tests is:curl/tests/unit/Makefile.am
Lines 48 to 50 in db12037
Changes
Removing unit1394_LDADD
These custom
unit1394_LDADDand similar automake overrides are no longer neded. They were originally added by added by 8dac7be for metalink support, but are no longer after 265b14d removed metalink.Removing unit1621_LDADD
The
unit1621_LDADDvariable has the exact same value as theLDADDflag inMakefile.am, except without@LDFLAGS@ @LIBCURL_LIBS@.This was originally added by 98e6629, but I can't see any reason why it exists, so we should remove it to clean things up.