cmake: support building static and shared libcurl in one go by vszakats · Pull Request #11505 · curl/curl

vszakats · 2023-07-24T00:16:15Z

This patch adds the ability to build a static and shared libcurl library
in a single build session. It also adds an option to select which one to
use when building the curl executable.

New build options:

BUILD_STATIC_LIBS. Default: OFF.
Enabled automatically if BUILD_SHARED_LIBS is OFF.
BUILD_STATIC_CURL. Default: OFF.
Requires BUILD_STATIC_LIBS enabled.
Enabled automatically if building static libcurl only.
STATIC_LIB_SUFFIX. Default: empty.
IMPORT_LIB_SUFFIX. Default: _imp if implib filename would collide
with static lib name (typically with MSVC) in Windows builds.
Otherwise empty.

Also:

Stop setting the CURL_STATICLIB macro via curl_config.h, and pass
it directly to the compiler. This also allows to delete a condition
from tests/server/CMakeLists.txt.
Complete a TODO by following the logic used in autotools (also for
LIBCURL_NO_SHARED), and set -DCURL_STATICLIB in Cflags: of
libcurl.pc for static-only curl builds.
Convert an existing CI test to build both shared and static libcurl.

Closes #11505

in debug + static libcurl builds https://ci.appveyor.com/project/curlorg/curl/builds/47622883

Follow the logic used in autotools and `LIBCURL_NO_SHARED` and set `-DCURL_STATICLIB` in `Cflags:` for static-only curl builds.

In preparation for single-pass shared/static CMake builds. Ref: curl/curl#11505

Affecting those that might be empty. ``` CMake Error at lib/CMakeLists.txt:160 (set_target_properties): set_target_properties called with incorrect number of arguments. ```

… shared Dependents rely on that behaviour: https://github.com/search?q=libcurl_imp&type=code

Making it clear that the measurement was done with separate shared and static build passes, and without this patch: curl/curl@1199308 curl/curl#11505

…elease [ci skip] Using this new cmake build option: curl/curl@1199308 curl/curl#11505

Follow-up to 1199308 curl#11505 Reported-by: balikalina on Github Fixes curl@1199308#r123923098 Closes #xxxxx

Replace (wrong) literal with a variable to specify the curl namespace. Follow-up to 1199308 #11505 Reported-by: balikalina on Github Fixes 1199308#r123923098 Closes #11629

Fixes: ``` [25/26] -- Found CURL: ***/build/parts/curl/install/lib64/cmake/CURL/CURLConfig.cmake (found version "8.3.0-DEV") [25/26] CMake Error at ***/build/parts/curl/install/lib64/cmake/CURL/CURLConfig.cmake:62 (add_library): [25/26] add_library cannot create ALIAS target "CURL::libcurl" because target [25/26] "CURL::libcurl_static" is imported but not globally visible. ``` Follow-up to 1199308 curl#11505 Reported-by: balikalina on Github Suggested-by: balikalina on Github Ref: curl#11629 (comment) Closes #xxxxx

This patch adds the ability to build a static and shared libcurl library in a single build session. It also adds an option to select which one to use when building the curl executable. New build options: - `BUILD_STATIC_LIBS`. Default: `OFF`. Enabled automatically if `BUILD_SHARED_LIBS` is `OFF`. - `BUILD_STATIC_CURL`. Default: `OFF`. Requires `BUILD_STATIC_LIBS` enabled. Enabled automatically if building static libcurl only. - `STATIC_LIB_SUFFIX`. Default: empty. - `IMPORT_LIB_SUFFIX`. Default: `_imp` if implib filename would collide with static lib name (typically with MSVC) in Windows builds. Otherwise empty. Also: - Stop setting the `CURL_STATICLIB` macro via `curl_config.h`, and pass it directly to the compiler. This also allows to delete a condition from `tests/server/CMakeLists.txt`. - Complete a TODO by following the logic used in autotools (also for `LIBCURL_NO_SHARED`), and set `-DCURL_STATICLIB` in `Cflags:` of `libcurl.pc` for _static-only_ curl builds. - Convert an existing CI test to build both shared and static libcurl. Closes curl#11505

Replace (wrong) literal with a variable to specify the curl namespace. Follow-up to 1199308 curl#11505 Reported-by: balikalina on Github Fixes curl@1199308#r123923098 Closes curl#11629

Switch from `curl-gnumake.sh` to `curl-cmake.sh` with upcoming curl release v8.5.0. cmake builds are now _faster_ for Windows builds than raw gnumake (aka `Makefile.mk`). They also use 'unity' mode, which makes builds run fast with the side-effect of also creating potentially more efficient binaries by allowing better compiler optimizations. This also makes curl-for-win use the same build system for all target platforms (`Makefile.mk` is not available for *nix platforms). Initially on 2022-07-04 cmake was 25% slower than gnumake. By 2022-09-26 this reduced to 20%, by 2023-07-29 to 18% and after the latest round of updates gnumake came out 7% slower than cmake. This is for Windows, for a triple x64, arm64 and x86 build. In absolute times this is 27m22s for cmake and 29m11s for gnumake. (FWIW autotools builds are 52% slower than cmake unity builds now.) Making cmake builds fast was a multi-year effort with these major steps: 1. add support for cmake builds in curl-for-win. 420e73c 2. bring it in-line with gnumake and autotools builds and tidy-up as much as possible. Scattered to a many commits. 3. delete a whole bunch of unused feature detections. curl/curl@4d73854 curl/curl#9044 (and a lot more smaller commits) 4. speed up picky warning option initialization by avoiding brute-force all options. (first in libssh2, then in curl, then applied also ngtcp2, nghttp3, nghttp2) curl/curl@9c543de curl/curl#10973 5. implement single build run for shared and static libcurl + tool (first in libssh2) curl/curl@1199308 curl/curl#11505 53dcd49 6. implement single build pass for shared and static libcurl (for Windows initially) curl/curl@2ebc74c curl/curl#11546 7. extend above to non-Windows (e.g. macOS) curl/curl@fc9bfb1 curl/curl#11627 bafa77d (mac) 1b27304 (linux) 8. implement unity builds: single compiler invocation for libcurl + tool curl/curl@3f8fc25 curl/curl#11095 curl/curl@f42a279 curl/curl#11928 67d7fd3 9. speed up 4x the cmake initialization phase (for Windows) curl/curl@2100d9f curl/curl#12044 10. speed up cmake initialization even more by pre-filling detection results for our well-known mingw-w64 environments. 74dd967 5a43c61 +1: speed up autotools initialization by mitigating a brute-force feature detection on Windows. This reduced total build times by 5 minutes at the time, for the 3 Windows targets in total. curl/curl@6adcff6 curl/curl#9591 Also update build times for cmake-unity and gnumake, based on runs: cmake-unity: https://ci.appveyor.com/project/curlorg/curl-for-win/builds/48357875 gnumake: https://ci.appveyor.com/project/curlorg/curl-for-win/builds/48358005

…etection Allow overriding the `IMPORT_LIB_SUFFIX` default with an empty value. Also: - add a fatal error if the implib and static lib filename are identical. - clarify `IMPORT_LIB_SUFFIX` default value in the documentation. Reported-by: RubisetCie on Github Fixes #16324 Ref: 1199308 #11505 Closes #16332

…etection Allow overriding the `IMPORT_LIB_SUFFIX` default with an empty value. Also: - add a fatal error if the implib and static lib filename are identical. - clarify `IMPORT_LIB_SUFFIX` default value in the documentation. Reported-by: RubisetCie on Github Fixes curl#16324 Ref: 1199308 curl#11505 Closes curl#16332

vszakats added the cmake label Jul 24, 2023

github-actions bot added cmdline tool tests CI Continuous Integration labels Jul 24, 2023

vszakats added the feature-window A merge of this requires an open feature window label Jul 24, 2023

vszakats force-pushed the cmake-dual branch from ef0d39e to 04debdb Compare July 24, 2023 16:28

vszakats added 5 commits July 24, 2023 18:15

step1

7e4de43

enable both static and shared in a test

2f26418

auto-select static curl if building static libcurl only

76061c0

attempt to fix tests/server build errors

88a5115

in debug + static libcurl builds https://ci.appveyor.com/project/curlorg/curl/builds/47622883

set CPPFLAG_CURL_STATICLIB for libcurl.pc

538f523

Follow the logic used in autotools and `LIBCURL_NO_SHARED` and set `-DCURL_STATICLIB` in `Cflags:` for static-only curl builds.

vszakats added enhancement and removed cmdline tool tests CI Continuous Integration labels Jul 24, 2023

vszakats added a commit to curl/curl-for-win that referenced this pull request Jul 24, 2023

curl-cmake.sh: rename two variables [ci skip]

6bb5dbd

In preparation for single-pass shared/static CMake builds. Ref: curl/curl#11505

vszakats added 2 commits July 25, 2023 10:07

merge set_target_properties() calls

1dd6e68

duplicate a comment

5556bcf

vszakats force-pushed the cmake-dual branch from 04debdb to 5556bcf Compare July 25, 2023 11:12

github-actions bot added cmdline tool tests CI Continuous Integration labels Jul 25, 2023

vszakats removed cmdline tool tests CI Continuous Integration labels Jul 25, 2023

github-actions bot added cmdline tool tests CI Continuous Integration labels Jul 25, 2023

try avoiding cmake error by quoting argument variables

9006c24

Affecting those that might be empty. ``` CMake Error at lib/CMakeLists.txt:160 (set_target_properties): set_target_properties called with incorrect number of arguments. ```

vszakats force-pushed the cmake-dual branch from 104fb82 to 9006c24 Compare July 25, 2023 16:28

vszakats added 3 commits July 27, 2023 11:46

correction to name collision avoidance logic

9980927

compatibility: always default to _imp suffix for implib when building…

eba7067

… shared Dependents rely on that behaviour: https://github.com/search?q=libcurl_imp&type=code

simplify

1ed0df0

vszakats force-pushed the cmake-dual branch from 0b8bc38 to 1ed0df0 Compare July 27, 2023 11:46

github-actions bot added cmdline tool tests CI Continuous Integration labels Jul 27, 2023

vszakats removed cmdline tool tests CI Continuous Integration feature-window A merge of this requires an open feature window labels Jul 27, 2023

vszakats closed this in 1199308 Jul 29, 2023

vszakats deleted the cmake-dual branch July 29, 2023 00:41

vszakats added a commit to curl/curl-for-win that referenced this pull request Jul 29, 2023

curl-cmake.sh: build static/shared libcurl in one go with next curl r…

53dcd49

…elease [ci skip] Using this new cmake build option: curl/curl@1199308 curl/curl#11505

vszakats added a commit to vszakats/curl that referenced this pull request Aug 8, 2023

cmake: use variable to set the namespace

2511be0

Follow-up to 1199308 curl#11505 Reported-by: balikalina on Github Fixes curl@1199308#r123923098 Closes #xxxxx

vszakats mentioned this pull request Aug 8, 2023

cmake: fix to use variable for the curl namespace #11629

Closed

vszakats mentioned this pull request Aug 9, 2023

[WIP] cmake: fix libcurl export alias #11646

Closed

vszakats mentioned this pull request Feb 12, 2024

CMake and Zlib madler/zlib#831

Closed

This was referenced Feb 13, 2025

Disabled forced Windows import library suffix, if static library is not built #16324

Closed

cmake: allow empty custom IMPORT_LIB_SUFFIX, add suffix collision detection #16332

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cmake: support building static and shared libcurl in one go#11505

cmake: support building static and shared libcurl in one go#11505
vszakats wants to merge 11 commits intocurl:masterfrom
vszakats:cmake-dual

vszakats commented Jul 24, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vszakats commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

vszakats commented Jul 24, 2023 •

edited

Loading