cmake: support building static and shared libcurl in one go #11505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
added
the
feature-window
in debug + static libcurl builds https://ci.appveyor.com/project/curlorg/curl/builds/47622883
Follow the logic used in autotools and `LIBCURL_NO_SHARED` and set `-DCURL_STATICLIB` in `Cflags:` for static-only curl builds.
vszakats
added
enhancement
and removed
cmdline tool
tests
CI
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 24, 2023
In preparation for single-pass shared/static CMake builds. Ref: curl/curl#11505
Affecting those that might be empty. ``` CMake Error at lib/CMakeLists.txt:160 (set_target_properties): set_target_properties called with incorrect number of arguments. ```
|
I replicated existing behaviour for compatibility where the implib is always named Though as discovered earlier, this past choice appears to be arbitrary. Also the A more widely used convention would be using It's an odd problem with no standard or perfect solution. Let me know if we should do any breaking changes here. |
… shared Dependents rely on that behaviour: https://github.com/search?q=libcurl_imp&type=code
vszakats
removed
cmdline tool
tests
CI
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 29, 2023
Making it clear that the measurement was done with separate shared and static build passes, and without this patch: curl/curl@1199308 curl/curl#11505
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 29, 2023
…elease [ci skip] Using this new cmake build option: curl/curl@1199308 curl/curl#11505
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 8, 2023
Follow-up to 1199308 curl#11505 Reported-by: balikalina on Github Fixes curl@1199308#r123923098 Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Aug 9, 2023
Replace (wrong) literal with a variable to specify the curl namespace. Follow-up to 1199308 #11505 Reported-by: balikalina on Github Fixes 1199308#r123923098 Closes #11629
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 9, 2023
Fixes: ``` [25/26] -- Found CURL: ***/build/parts/curl/install/lib64/cmake/CURL/CURLConfig.cmake (found version "8.3.0-DEV") [25/26] CMake Error at ***/build/parts/curl/install/lib64/cmake/CURL/CURLConfig.cmake:62 (add_library): [25/26] add_library cannot create ALIAS target "CURL::libcurl" because target [25/26] "CURL::libcurl_static" is imported but not globally visible. ``` Follow-up to 1199308 curl#11505 Reported-by: balikalina on Github Suggested-by: balikalina on Github Ref: curl#11629 (comment) Closes #xxxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 11, 2023
Fixes: ``` [25/26] -- Found CURL: ***/build/parts/curl/install/lib64/cmake/CURL/CURLConfig.cmake (found version "8.3.0-DEV") [25/26] CMake Error at ***/build/parts/curl/install/lib64/cmake/CURL/CURLConfig.cmake:62 (add_library): [25/26] add_library cannot create ALIAS target "CURL::libcurl" because target [25/26] "CURL::libcurl_static" is imported but not globally visible. ``` Follow-up to 1199308 curl#11505 Reported-by: balikalina on Github Suggested-by: balikalina on Github Ref: curl#11629 (comment) Closes #xxxxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to build a static and shared libcurl library
in a single build session. It also adds an option to select which one to
use when building the curl executable.
New build options:
BUILD_STATIC_LIBS. Default:OFF.Enabled automatically if
BUILD_SHARED_LIBSisOFF.BUILD_STATIC_CURL. Default:OFF.Requires
BUILD_STATIC_LIBSenabled.Enabled automatically if building static libcurl only.
STATIC_LIB_SUFFIX. Default: empty.IMPORT_LIB_SUFFIX. Default:_impif implib filename would collidewith static lib name (typically with MSVC) in Windows builds.
Otherwise empty.
Also:
Stop setting the
CURL_STATICLIBmacro viacurl_config.h, and passit directly to the compiler. This also allows to delete a condition
from
tests/server/CMakeLists.txt.Complete a TODO by following the logic used in autotools (also for
LIBCURL_NO_SHARED), and set-DCURL_STATICLIBinCflags:oflibcurl.pcfor static-only curl builds.Convert an existing CI test to build both shared and static libcurl.
Closes #11505