tests, fix h3 server check and parallel instances #11553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix check for availability of nghttpx server - add `tcp` frontend config for same port as quic, as without this, port 3000 is bound which clashes for parallel testing
bagder
approved these changes
Jul 31, 2023
dfandrich
requested changes
Jul 31, 2023
tests/http3-server.pl
Outdated
| "--frontend=\"*,$listenport;quic\" ". | ||
| "--log-level=INFO ". | ||
| "--pid-file=$pidfile ". | ||
| "--errorlog-file=$logfile ". | ||
| "--conf=$conf ". | ||
| "$keyfile $certfile"; | ||
| print "RUN: $cmdline\n" if($verbose); | ||
| print "RUN: $cmdline\n" if($verbose or 1); |
There was a problem hiding this comment.
"or 1" looks like a debugging leftover
There was a problem hiding this comment.
Thanks for catching this!
bagder
approved these changes
Aug 1, 2023
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- fix check for availability of nghttpx server - add `tcp` frontend config for same port as quic, as without this, port 3000 is bound which clashes for parallel testing Closes curl#11553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcpfrontend config for same port as quic, as without this, port 3000 is bound which clashes for parallel testing