egd: delete feature detection and related source code#11556
Closed
vszakats wants to merge 5 commits intocurl:masterfrom
Closed
egd: delete feature detection and related source code#11556vszakats wants to merge 5 commits intocurl:masterfrom
vszakats wants to merge 5 commits intocurl:masterfrom
Conversation
bagder
approved these changes
Jul 31, 2023
Member
Author
|
Managed to fix this as a side-effect of adding |
Because OpenSSL libs are not linked at this point. The feature could still be (probably) force-enabled manually by setting `EGD_SOCKET` and `HAVE_RAND_EGD`, and using a sufficiently obsolete OpenSSL version. Closes #xxxxx
vszakats
changed the title
HAVE_RAND_EGD detectionHAVE_RAND_EGD detection
bagder
approved these changes
Aug 1, 2023
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Looks good, but I think there are a few more traces of RAND_EGD you can wipe out while at it:
$ git grep -l RAND_EGD | wc -l
10
Member
Author
|
autotools detects Do we want to also delete autotools detections bits? and the actual use inside |
Member
Yes let's do that. I think that was only for OpenSSL before 1.1 and already then I believe very few actually used this. |
vszakats
changed the title
HAVE_RAND_EGD detection
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
EGD is Entropy Gathering Daemon, a socket-based entropy source supported by pre-OpenSSL v1.1 versions and now deprecated. curl also deprecated it a while ago. Its detection in CMake was broken all along because OpenSSL libs were not linked at the point of feature check. Delete detection from both cmake and autotools, along with the related source snippet, and the `--with-egd-socket=` `./configure` option. Closes curl#11556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EGD is Entropy Gathering Daemon, a socket-based entropy source supported
by pre-OpenSSL v1.1 versions and now deprecated. curl also deprecated it
a while ago.
Its detection in CMake was broken all along because OpenSSL libs were
not linked at the point of feature check.
Delete detection from both cmake and autotools, along with the related
source snippet, and the
--with-egd-socket=./configureoption.Closes #11556