H2 upgrade tests and mitigations #11563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check in h2 filter recv that stream actually exists and return error if not - add test for parallel, extreme h2 upgrades that fail if connections get reused before fully switched - add h2 upgrade upload test just for completeness
- added in test_02_25 with special client - added xfer-conn-id logging for DEBUG builds in standard library debug function
… non-debug builds check those.
…e transfer count, increasing client timeout value
bagder
approved these changes
Aug 2, 2023
|
Ok, bearssl and libressl fail the new test with timeouts. Investigating... |
|
I believe this is ready for merge now. |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- check in h2 filter recv that stream actually exists and return error if not - add test for parallel, extreme h2 upgrades that fail if connections get reused before fully switched - add h2 upgrade upload test just for completeness Closes curl#11563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While issue of premature connection sharing with ongoing HTTP/2 Upgrades (https://curl.se/mail/lib-2023-07/0045.html) was fixed in d4618a3, this PR adds a test case for the original problem and some additional mitigation.
http2.cfor being called with an unknown transfer, giving CURLE_HTTP2 instead of a crash