New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: don't use OpenSSL's ERR_PACK. #1157

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@agl
Contributor

agl commented Dec 7, 2016

ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
function name must be specified which is overly specific: the test will
break whenever OpenSSL internally change things so that a different
function creates the error.

vtls: don't use OpenSSL's ERR_PACK.
ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
function name must be specified which is overly specific: the test will
break whenever OpenSSL internally change things so that a different
function creates the error.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Dec 7, 2016

@agl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rousskov, @bagder and @ghedo to be potential reviewers.

mention-bot commented Dec 7, 2016

@agl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rousskov, @bagder and @ghedo to be potential reviewers.

@bagder

bagder approved these changes Dec 7, 2016

@bagder bagder closed this in 71a5553 Dec 7, 2016

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Dec 7, 2016

Member

thanks!

Member

bagder commented Dec 7, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment