vtls: don't use OpenSSL's ERR_PACK. #1157

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@agl
Contributor
agl commented Dec 7, 2016

ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
function name must be specified which is overly specific: the test will
break whenever OpenSSL internally change things so that a different
function creates the error.

@agl agl vtls: don't use OpenSSL's ERR_PACK.
ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
function name must be specified which is overly specific: the test will
break whenever OpenSSL internally change things so that a different
function creates the error.
b2e16d4
@mention-bot

@agl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rousskov, @bagder and @ghedo to be potential reviewers.

@bagder
bagder approved these changes Dec 7, 2016 View changes
@bagder bagder added a commit that closed this pull request Dec 7, 2016
@agl @bagder agl + bagder openssl: don't use OpenSSL's ERR_PACK.
ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
function name must be specified which is overly specific: the test will
break whenever OpenSSL internally change things so that a different
function creates the error.

Closes #1157
71a5553
@bagder bagder closed this in 71a5553 Dec 7, 2016
@bagder
Member
bagder commented Dec 7, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment