openssl: auto-detect SSL_R_TLSV13_ALERT_CERTIFICATE_REQUIRED#11617
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
openssl: auto-detect SSL_R_TLSV13_ALERT_CERTIFICATE_REQUIRED#11617vszakats wants to merge 1 commit intocurl:masterfrom
SSL_R_TLSV13_ALERT_CERTIFICATE_REQUIRED#11617vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
OpenSSL 1.1.1 defines this macro, but no ealier version, or any of the popular forks (yet). Use the macro itself to detect its presence, replacing the hard-wired fork-specific conditions. This way the feature will enable automatically when forks implement it, while also shorter and possibly requiring less future maintenance. Follow-up to 94241a9 curl#6721 Closes curl#11617
jay
approved these changes
Aug 8, 2023
bagder
approved these changes
Aug 8, 2023
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
OpenSSL 1.1.1 defines this macro, but no ealier version, or any of the popular forks (yet). Use the macro itself to detect its presence, replacing the hard-wired fork-specific conditions. This way the feature will enable automatically when forks implement it, while also shorter and possibly requiring less future maintenance. Follow-up to 94241a9 curl#6721 Reviewed-by: Jay Satiro Closes curl#11617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 1.1.1 defines this macro, but no ealier version, or any of the popular forks (yet). Use the macro itself to detect its presence, replacing the hard-wired fork-specific conditions.
This way the feature will enable automatically when forks implement it, while also shorter and possibly requiring less future maintenance.
Follow-up to 94241a9 #6721
Closes #11617