cmake: assume wldap32 availability on Windows#11624
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
cmake: assume wldap32 availability on Windows#11624vszakats wants to merge 1 commit intocurl:masterfrom
wldap32 availability on Windows#11624vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
This system library first shipped with Windows ME, available as an extra install for some older releases (according to [1]). The import library was present already in old MinGW 3.4.2 (year 2007). Drop the feature check and the associated `HAVE_WLDAP32` variable. You can continue to manually disable `wldap32` with the `USE_WIN32_LDAP=OFF` CMake option. [1]: https://dlcdn.apache.org/httpd/binaries/win32/LEGACY.html Closes #xxxxx
jay
approved these changes
Aug 9, 2023
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
This system library first shipped with Windows ME, available as an extra install for some older releases (according to [1]). The import library was present already in old MinGW 3.4.2 (year 2007). Drop the feature check and its associated `HAVE_WLDAP32` variable. To manually disable `wldap32`, you can use the `USE_WIN32_LDAP=OFF` CMake option, like before. [1]: https://dlcdn.apache.org/httpd/binaries/win32/LEGACY.html Reviewed-by: Jay Satiro Closes curl#11624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This system library first shipped with Windows ME, available as an extra
install for some older releases (according to 1). The import library
was present already in old MinGW 3.4.2 (year 2007).
Drop the feature check and the associated
HAVE_WLDAP32variable.To manually disable
wldap32, you can use theUSE_WIN32_LDAP=OFFCMake option, like before.
Closes #11624
Footnotes
https://dlcdn.apache.org/httpd/binaries/win32/LEGACY.html ↩