tests: add a test to check translatable string options in OS400 wrapper #11650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monnerat
force-pushed
the
check-translatable-options
branch
2 times, most recently
from
b21ae76 to
0ee0635
Compare
|
Otherwise looks fine to me. |
monnerat
force-pushed
the
check-translatable-options
branch
from
0ee0635 to
2afe39a
Compare
Thanks for your review. All your remarks are now taken into account. I've added a commit that removes the now redundant build time translatable string options check on OS/400: if kept, it would have only signaled false positives! |
monnerat
force-pushed
the
check-translatable-options
branch
from
2afe39a to
6fcfc4c
Compare
This test runs a perl script that checks all string options are properly translated by the OS400 character code conversion wrapper. It also verifies these options are listed in alphanumeric order in the wrapper switch statement.
Now that there is a test for this, the build time check is not needed anymore.
monnerat
force-pushed
the
check-translatable-options
branch
from
6fcfc4c to
59d2c92
Compare
bagder
approved these changes
Aug 17, 2023
bagder
pushed a commit
that referenced
this pull request
Aug 17, 2023
Now that there is a test for this, the build time check is not needed anymore. Closes #11650
|
Thanks for merge :-) |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
This test runs a perl script that checks all string options are properly translated by the OS400 character code conversion wrapper. It also verifies these options are listed in alphanumeric order in the wrapper switch statement. Closes curl#11650
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Now that there is a test for this, the build time check is not needed anymore. Closes curl#11650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test runs a perl script that checks all string options are properly translated by the OS400 character code conversion wrapper. It also verifies these options are listed in alphanumeric order in the wrapper switch statement.