-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urlapi: add ability to convert back from punycode to IDN name #11655
Conversation
I wrote the windows code "blind" based on this documentation. |
So 4 Windows builds fail, the others work!? The test 1560 error output is awesomely weird and hard to detect. in Circle CI it looks like this:
But when I copy and pasted it here, it shows:
Assuming I get the correct trailing byte, it is 0x16. |
I think you should have passed the length of i don't know where -1 comes from maybe that was in earlier versions of the doc i will check |
I just guessed on the -1 since it seems to work for the conversion in the other direction... |
I just checked an old Windows SDK offline documentation from Windows 7 2009 and I do not see it documented there either so I don't know why we did it that way. I will change it. |
awesome @jay, that seems to have done it! |
Asssisted-by: Jay Satiro Closes curl#11655
Upcoming in libcurl 8.3.0 curl/curl@c350069 curl/curl#11655 Origin: e9ce94d7a6706b8cf283c088504953864e590474
No description provided.