Add CURL_OFF_T definitions on HP-UX with HP aCC

[michael-o]

HP-UX on IA64 provides two modes: 32 and 64 bit while 32 bit being the default one. Use "long long" in 32 bit mode and just "long" in 64 bit mode.

====================
Determined with:

osipovmi@deblndw024v:~
$ cat sizeof.c
#include <stdio.h>
#include <sys/types.h>
#include <sys/socket.h>

int main(void) {
#ifdef _LP64
        printf("_LP64 defined\n");
#endif
        printf("size of int: %zd\n", sizeof(int));
        printf("size of long: %zd\n", sizeof(long));
        printf("size of long long: %zd\n", sizeof(long long));
        printf("size of off_t: %zd\n", sizeof(off_t));
        printf("size of socklen_t: %zd\n", sizeof(socklen_t));
    return 0;
}
osipovmi@deblndw024v:~
$ for opts in "+DD32" "+DD32 -D_FILE_OFFSET_BITS=64" "+DD64"; do aCC -AC99 $opts sizeof.c -o sizeof; echo $opts; ./sizeof; done
+DD32
size of int: 4
size of long: 4
size of long long: 8
size of off_t: 4
size of socklen_t: 4
+DD32 -D_FILE_OFFSET_BITS=64
size of int: 4
size of long: 4
size of long long: 8
size of off_t: 8
size of socklen_t: 4
+DD64
_LP64 defined
size of int: 4
size of long: 8
size of long long: 8
size of off_t: 8
size of socklen_t: 8

Objects in both modes:

root@deblndw002x:/var/tmp/ports/work/curl-8.2.1
# ldd ./src/.libs/curl

./src/.libs/curl:
        libcurl.so.12 =>        /opt/ports/lib/hpux32/libcurl.so.12
        libssl.so.1.1 =>        /usr/lib/hpux32/libssl.so.1.1
        libcrypto.so.1.1 =>     /usr/lib/hpux32/libcrypto.so.1.1
        libgssapi_krb5.2 =>     /opt/ports/lib/hpux32/libgssapi_krb5.2
        libkrb5.3 =>    /opt/ports/lib/hpux32/libkrb5.3
        libk5crypto.3 =>        /opt/ports/lib/hpux32/libk5crypto.3
        libcom_err.3 => /opt/ports/lib/hpux32/libcom_err.3
        libz.so =>      /opt/ports/lib/hpux32/libz.so
        libc.so.1 =>    /usr/lib/hpux32/libc.so.1
        libcrypto.so.1.1 =>     /usr/lib/hpux32/libcrypto.so.1.1
        libdl.so.1 =>   /usr/lib/hpux32/libdl.so.1
        libpthread.so.1 =>      /usr/lib/hpux32/libpthread.so.1
        libkrb5support.0 =>     /opt/ports/lib/hpux32/libkrb5support.0
        libintl.so.11 =>        /opt/ports/lib/hpux32/libintl.so.11
        libc.so.1 =>    /usr/lib/hpux32/libc.so.1
        libdl.so.1 =>   /usr/lib/hpux32/libdl.so.1
        libiconv.so.8 =>        /opt/ports/lib/hpux32/libiconv.so.8
        libc.so.1 =>    /usr/lib/hpux32/libc.so.1
        libc.so.1 =>    /usr/lib/hpux32/libc.so.1
root@deblndw002x:/var/tmp/ports/work/curl-8.2.1
# file ./src/.libs/curl
./src/.libs/curl:       ELF-32 executable object file - IA64


root@deblndw002x:/var/tmp/ports/work/curl-8.2.1
# LD_LIBRARY_PATH=./lib/.libs ldd ./src/.libs/curl

./src/.libs/curl:
        libcurl.so.12 =>        ./lib/.libs/libcurl.so.12
        libssl.so.1.1 =>        /usr/lib/hpux64/libssl.so.1.1
        libcrypto.so.1.1 =>     /usr/lib/hpux64/libcrypto.so.1.1
        libgssapi_krb5.so =>    /usr/lib/hpux64/libgssapi_krb5.so
        libkrb5.so =>   /usr/lib/hpux64/libkrb5.so
        libk5crypto.so =>       /usr/lib/hpux64/libk5crypto.so
        libcom_err.so =>        /usr/lib/hpux64/libcom_err.so
        libc.so.1 =>    /usr/lib/hpux64/libc.so.1
        libcrypto.so.1.1 =>     /usr/lib/hpux64/libcrypto.so.1.1
        libdl.so.1 =>   /usr/lib/hpux64/libdl.so.1
        libpthread.so.1 =>      /usr/lib/hpux64/libpthread.so.1
        libkrb5.so =>   /usr/lib/hpux64/libkrb5.so
        libk5crypto.so =>       /usr/lib/hpux64/libk5crypto.so
        libcom_err.so =>        /usr/lib/hpux64/libcom_err.so
        libkrb5support.so =>    /usr/lib/hpux64/libkrb5support.so
        libkrb5support.so =>    /usr/lib/hpux64/libkrb5support.so
        libkrb5support.so =>    /usr/lib/hpux64/libkrb5support.so
        libdl.so.1 =>   /usr/lib/hpux64/libdl.so.1
root@deblndw002x:/var/tmp/ports/work/curl-8.2.1
# file ./src/.libs/curl
./src/.libs/curl:       ELF-64 executable object file - IA64

Don't be surprised hat the linked libraries in 64 bit mode are different, I don't build our entire stack in 64 bit, but on 32 bit only because it is enough for us.

[bagder]

Thanks!

[NagarajuGunda]

With this fix, our build which worked earlier is failing with socket connection because now the size of curl_socklen_t is 8

This seems to be an issue on HP-UX

https://lists.nongnu.org/archive/html/bug-gnulib/2018-01/msg00083.html

Need to use additional flags for the curl to work correctly after this change

I've used the below flags for my build to work

CFLAGS="+DD64 -AC99 -D_XOPEN_SOURCE=500 -D_HPUX_ALT_XOPEN_SOCKET_API -mt"

[michael-o]

With this fix, our build which worked earlier is failing with socket connection because now the size of curl_socklen_t is 8

This seems to be an issue on HP-UX

https://lists.nongnu.org/archive/html/bug-gnulib/2018-01/msg00083.html

Need to use additional flags for the curl to work correctly after this change

I've used the below flags for my build to work

CFLAGS="+DD64 -AC99 -D_XOPEN_SOURCE=500 -D_HPUX_ALT_XOPEN_SOCKET_API -mt"

Is is because you compile in wide mode? Moreover, the reference is for gnulib, how is this related to curl?