secureserver.pl: fix stunnel path quoting#11721
Closed
jay wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
- Store the stunnel path in the private variable $stunnel unquoted and instead quote it in the command strings. Prior to this change the quoted stunnel path was passed to perl's file operators which cannot handle quoted paths. For example: $stunnel = "\"/C/Program Files (x86)/stunnel/bin/tstunnel\""; if(-x $stunnel or -x "$stunnel") # false even if path exists and is executable Our other test scripts written in perl, unlike this one, use servers.pm which has a global $stunnel variable with the path stored unquoted and therefore those scripts don't have this problem. Closes #xxxx
Contributor
|
LGTM |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- Store the stunnel path in the private variable $stunnel unquoted and instead quote it in the command strings. Prior to this change the quoted stunnel path was passed to perl's file operators which cannot handle quoted paths. For example: $stunnel = "\"/C/Program Files (x86)/stunnel/bin/tstunnel\""; if(-x $stunnel or -x "$stunnel") # false even if path exists and is executable Our other test scripts written in perl, unlike this one, use servers.pm which has a global $stunnel variable with the path stored unquoted and therefore those scripts don't have this problem. Closes curl#11721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change the quoted stunnel path was passed to perl's file operators which cannot handle quoted paths. For example:
Our other test scripts written in perl, unlike this one, use servers.pm which has a global $stunnel variable with the path stored unquoted and therefore those scripts don't have this problem.
Closes #xxxx