#if CURL_BUILD_MAC_10_7 || CURL_BUILD_IOS
status = 1
I haven't been able to independently verify whether client certificate matching works on any version of iOS or macOS, before or after this change. @schweikert, @nickzman, would you be able to help with that? Presumably, this change is no worse for iOS than what we had before #1105.
darwinssl: fix iOS build
darwinssl: fix CFArrayRef leak
@chris-araman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schweikert, @nickzman and @bagder to be potential reviewers.
checksrc: fix style defects
Unfortunately I can't test this, because I don't have access to a web server requesting a client-certificate anymore. The patch looks good to me though.
Thanks for this, and sorry for breaking the build on iOS.
No worries, @schweikert. Thanks for contributing!
Shouldn't this just be #else?
I considered that, but thought this would be clearer, especially if the outer #if ever changes. Feel free to change it, or require that I do.
Sorry for the late approval. The change looks okay to me, and doesn't break the build. I didn't have time to test this under iOS with a client certificate in the keychain, but in theory, this ought to work.
No problem. Holiday and such. Thanks!
Reviewed-by: Nick Zitzmann
Thanks, both of you!