darwinssl: fix iOS build and CFArrayRef leak #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-araman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schweikert, @nickzman and @bagder to be potential reviewers. |
|
Unfortunately I can't test this, because I don't have access to a web server requesting a client-certificate anymore. The patch looks good to me though. Thanks for this, and sorry for breaking the build on iOS. |
|
No worries, @schweikert. Thanks for contributing! |
chris-araman
changed the title
nickzman
reviewed
Dec 24, 2016
| if(err == noErr) { | ||
| #if CURL_BUILD_IOS | ||
| common_name = SecCertificateCopySubjectSummary(cert); | ||
| #elif CURL_BUILD_MAC_10_7 |
There was a problem hiding this comment.
I considered that, but thought this would be clearer, especially if the outer #if ever changes. Feel free to change it, or require that I do.
nickzman
approved these changes
Dec 26, 2016
|
No problem. Holiday and such. Thanks! |
|
Thanks, both of you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1172
SecCertificateCopySubjectSummaryon iOS as we do inCopyCertSubjectSecIdentityRefand release the others withCFRelease(keys_list)#if CURL_BUILD_MAC_10_7 || CURL_BUILD_IOSblock to avoid unused locals warnings on other targetsstatus = 1in caseSecItemCopyMatchingyields an empty setI haven't been able to independently verify whether client certificate matching works on any version of iOS or macOS, before or after this change. @schweikert, @nickzman, would you be able to help with that? Presumably, this change is no worse for iOS than what we had before #1105.