tool_paramhlp: improve str2num() by avoiding unnecessary call to strlen()#11742
Closed
foutaise wants to merge 1 commit intocurl:masterfrom
foutaise:master
Closed
tool_paramhlp: improve str2num() by avoiding unnecessary call to strlen()#11742foutaise wants to merge 1 commit intocurl:masterfrom foutaise:master
foutaise wants to merge 1 commit intocurl:masterfrom
foutaise:master
Conversation
Member
|
Thanks! |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reading @bagder last blog entry regarding CVE-2020-19909, I had a look to str2num() function and realized that a small improvement might be applied to avoid an unnecessary call to strlen().