cmake: add support for CURL_DEFAULT_SSL_BACKEND
#11774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow overriding the default TLS backend via a CMake setting. E.g.: `cmake [...] -DCURL_DEFAULT_SSL_BACKEND=mbedtls` Accepted values: bearssl, gnutls, mbedtls, openssl, rustls, schannel, secure-transport, wolfssl The string is baked into the final binary as a string. The value is case-insensitive. We added a similar option to autotools in 2017 via c7170e2. Closes #xxxxx
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 31, 2023
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 31, 2023
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 31, 2023
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 31, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 1, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 3, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 3, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 3, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 3, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 3, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 6, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 7, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 7, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 7, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 7, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 20, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 20, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 22, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 22, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 22, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 23, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 23, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 24, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Allow overriding the default TLS backend via a CMake setting. E.g.: `cmake [...] -DCURL_DEFAULT_SSL_BACKEND=mbedtls` Accepted values: bearssl, gnutls, mbedtls, openssl, rustls, schannel, secure-transport, wolfssl The passed string is baked into the curl/libcurl binaries. The value is case-insensitive. We added a similar option to autotools in 2017 via c7170e2. TODO: Convert to lowercase to improve reproducibility. Closes curl#11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 27, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 28, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 28, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Sep 28, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 30, 2023
Before this patch CMake builds accepted any value and it was used at runtime as-is. This patch make sure that the selected default backend is also enabled in the build. It also enforces a full lowercase value. This improves reproducibility. This brings CMake closer to autotools which already worked like described above. Follow-up to 26c7feb curl#11774 Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Sep 30, 2023
Before this patch CMake builds accepted any value and it was used at runtime as-is. This patch make sure that the selected default backend is also enabled in the build. It also enforces a full lowercase value. This improves reproducibility and brings CMake in sync with autotools which already worked like described above. Follow-up to 26c7feb #11774 Closes #11998
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Oct 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Oct 2, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Oct 3, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Oct 5, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Oct 7, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Oct 7, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to vszakats/curl-for-win
that referenced
this pull request
Oct 7, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb https://github dot com/curl/curl/pull/11774
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Oct 8, 2023
The 8.3.0-specific logic depends on this: curl/curl@26c7feb curl/curl#11774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding the default TLS backend via a CMake setting.
E.g.:
cmake [...] -DCURL_DEFAULT_SSL_BACKEND=mbedtlsAccepted values: bearssl, gnutls, mbedtls, openssl, rustls,
schannel, secure-transport, wolfssl
The passed string is baked into the curl/libcurl binaries.
The value is case-insensitive.
We added a similar option to autotools in 2017 via
c7170e2.
TODO: Convert to lowercase to improve reproducibility.
Closes #11774