hyper: fix a progress upload counter bug#11780
hyper: fix a progress upload counter bug#11780nnethercote wants to merge 1 commit intocurl:masterfrom
Conversation
`Curl_pgrsSetUploadCounter` should be a passed a total count, not an increment. This changes the failing diff for test 579 with hyper from this: ``` Progress callback called with UL 0 out of 0[LF] -Progress callback called with UL 8 out of 0[LF] -Progress callback called with UL 16 out of 0[LF] -Progress callback called with UL 26 out of 0[LF] -Progress callback called with UL 61 out of 0[LF] -Progress callback called with UL 66 out of 0[LF] +Progress callback called with UL 29 out of 0[LF] ``` to this: ``` Progress callback called with UL 0 out of 0[LF] -Progress callback called with UL 8 out of 0[LF] -Progress callback called with UL 16 out of 0[LF] -Progress callback called with UL 26 out of 0[LF] -Progress callback called with UL 61 out of 0[LF] -Progress callback called with UL 66 out of 0[LF] +Progress callback called with UL 40 out of 0[LF] ``` Presumably a step in the right direction.
18c09c8 to
7341176
Compare
I more or less understand the differences here now. The test has this data that gets sent: Vanilla curl gets an update for each entry, which is why there are five entries after the initial curl+hyper ends up doing things slightly differently: it doesn't include the hexlen/EOL chars, so we end up with 3 + 3 + 5 + 29 + 0 = 40 chars. Also, it doesn't call I don't know if these differences are important. Maybe it's worth having different expected output for the hyper build? |
|
Thanks! |
`Curl_pgrsSetUploadCounter` should be a passed a total count, not an increment. This changes the failing diff for test 579 with hyper from this: ``` Progress callback called with UL 0 out of 0[LF] -Progress callback called with UL 8 out of 0[LF] -Progress callback called with UL 16 out of 0[LF] -Progress callback called with UL 26 out of 0[LF] -Progress callback called with UL 61 out of 0[LF] -Progress callback called with UL 66 out of 0[LF] +Progress callback called with UL 29 out of 0[LF] ``` to this: ``` Progress callback called with UL 0 out of 0[LF] -Progress callback called with UL 8 out of 0[LF] -Progress callback called with UL 16 out of 0[LF] -Progress callback called with UL 26 out of 0[LF] -Progress callback called with UL 61 out of 0[LF] -Progress callback called with UL 66 out of 0[LF] +Progress callback called with UL 40 out of 0[LF] ``` Presumably a step in the right direction. Closes curl#11780
Curl_pgrsSetUploadCountershould be a passed a total count, not an increment.This changes the failing diff for test 579 with hyper from this:
to this:
Presumably a step in the right direction.