New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl_auth_decode_digest_http_message(): copy terminating NUL #1180

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mkhon
Contributor

mkhon commented Dec 28, 2016

Curl_auth_decode_digest_http_message(): copy terminating NUL as later Curl_override_sspi_http_realm() expects a NUL-terminated string.

Curl_auth_decode_digest_http_message(): copy terminating NUL as later
Curl_override_sspi_http_realm() expects a NUL-terminated string.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Dec 28, 2016

@mkhon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @jay and @bagder to be potential reviewers.

mention-bot commented Dec 28, 2016

@mkhon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @jay and @bagder to be potential reviewers.

@mkhon

This comment has been minimized.

Show comment
Hide comment
@mkhon

mkhon Dec 28, 2016

Contributor

The bug was introduced in 500d2db

Contributor

mkhon commented Dec 28, 2016

The bug was introduced in 500d2db

@bagder bagder closed this in 89b7898 Dec 28, 2016

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Dec 28, 2016

Member

Thanks!

Member

bagder commented Dec 28, 2016

Thanks!

@mkhon mkhon deleted the mkhon:digest-sspi-fix branch Dec 29, 2016

mkhon added a commit to mkhon/curl that referenced this pull request Dec 31, 2016

digest_sspi: copy terminating NUL as well
Curl_auth_decode_digest_http_message(): copy terminating NUL as later
Curl_override_sspi_http_realm() expects a NUL-terminated string.

Fixes #1180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment