Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: only start the happy eyeballs timer when needed #11939

wants to merge 1 commit into from


Copy link

@hwti hwti commented Sep 25, 2023

The timeout is only used when there is a second address family, for the delayed eyeballer.

The timeout is only used when there is a second address family, for the delayed eyeballer.
Copy link

@icing icing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct.

@bagder bagder closed this in b5bb84c Sep 28, 2023
Copy link

bagder commented Sep 28, 2023


@dfandrich dfandrich mentioned this pull request Oct 4, 2023
3 tasks
@hwti hwti deleted the happy-eyeballs-timer branch October 11, 2023 11:12
ehuss added a commit to ecnelises/curl-rust that referenced this pull request Oct 11, 2023
This test is hanging on Linux with the 8.4.0 update.

My poor understanding is that `perform()` should not be used with
`curl_multi_socket_action` (that is, it should only use `perform` or
`action`, not both). Removing this seems to fix things.

Note that there were some other hang-related changes in the 8.4.0
release. I bisected the hang to curl/curl#11939,
which then uncovered some curl tests that were hanging in
curl/curl#12033. That then spawned off
two more changes to fix the hangs (both of which are also in 8.4.0).
However, this upload_lots was still failing. I think this is likely
due to an incorrect use of the API poorly interacting with the timer
changes in 8.4.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

3 participants