cmake: move global headers to specific checks #11951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on autotools logic in `m4/curl-functions.m4`.
Based on autotools logic in `m4/curl-functions.m4`, `stddef.h` isn't necessary for any detection.
Based on autotools logic in `m4/curl-functions.m4`.
I missed it in 96c2990 curl#11940
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 5, 2023
We removed C89 `setjmp.h` and `signal.h` detections and excluded them from the global header list we use for detecting functions [1]. Then missed to re-add these headers to the specific functions which need them to be detected [2]. Fix this omission in this patch. `sigsetjmp` has a second detection attempt documented as 'special' in the comment. However this detection uses the same method as the first attempt, with the difference of using `setjmp.h` header only, without including the rest of non-standard headers detected. It detects both function and macro like the first attempt. This second attempt seems redundant. It's been there since the initial commit of CMake support. [1] Follow-up to 3795fcd curl#11951 [2] Follow-up to 96c2990 curl#11940 Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Oct 6, 2023
We removed C89 `setjmp.h` and `signal.h` detections and excluded them from the global header list we use when detecting functions [1]. Then missed to re-add these headers to the specific functions which need them to be detected [2]. Fix this omission in this patch. [1] Follow-up to 3795fcd #11951 [2] Follow-up to 96c2990 #11940 Closes #12043
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this pull request
Nov 28, 2023
Before this patch we added standard headers unconditionally to the global list of headers used for feature checks. This is unnecessary and also doesn't help CMake 'Generate' performance. This patch moves these headers to each feature check where they are actually needed. Stop using `stddef.h`, as it seems unnecessary. I've used autotools' `m4/curl-functions.m4` to figure out these dependencies. Also delete checking for the C89 standard header `time.h`, that I missed in the earlier commit. Ref: 96c2990 curl#11940 Closes curl#11951
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this pull request
Nov 28, 2023
We removed C89 `setjmp.h` and `signal.h` detections and excluded them from the global header list we use when detecting functions [1]. Then missed to re-add these headers to the specific functions which need them to be detected [2]. Fix this omission in this patch. [1] Follow-up to 3795fcd curl#11951 [2] Follow-up to 96c2990 curl#11940 Closes curl#12043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we added standard headers unconditionally to the
global list of headers used for feature checks. This is unnecessary
and also doesn't help CMake 'Generate' performance. This patch moves
these headers to each feature check where they are actually needed.
Stop using
stddef.h, as it seems unnecessary.I've used autotools'
m4/curl-functions.m4to figure out thesedependencies.
Also delete checking for the C89 standard header
time.h, that Imissed in the earlier commit.
Ref: 96c2990 #11940
Closes #11951