Increase lib571 timeout from 3s to 30s #12013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
icing
commented
Oct 3, 2023
icing
commented
- 3s is too short for our CI, making this test fail occasionally
- test usually experiences no delay run locally, so 30s wont hurt
- 3s is too short for our CI, making this test fail occasionally - test usually experiences no delay run locally, so 30s wont hurt
|
Should we also re-enable 571 for these tests to see how they improve?: diff --git a/appveyor.yml b/appveyor.yml
index 70da472de..ce36cfff9 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -94,7 +94,7 @@ environment:
ENABLE_UNICODE: 'ON'
HTTP_ONLY: 'OFF'
TESTING: 'ON'
- DISABLED_TESTS: '~571 !1139 !1501'
+ DISABLED_TESTS: '!1139 !1501'
ADD_PATH: 'C:\msys64\usr\bin'
- job_name: 'CMake, VS2022, Debug x64, no SSL, Static'
APPVEYOR_BUILD_WORKER_IMAGE: 'Visual Studio 2022'
@@ -106,7 +106,7 @@ environment:
ENABLE_UNICODE: 'OFF'
HTTP_ONLY: 'OFF'
TESTING: 'ON'
- DISABLED_TESTS: '~571 !1139 !1501'
+ DISABLED_TESTS: '!1139 !1501'
ADD_PATH: 'C:\msys64\usr\bin'
- job_name: 'CMake, VS2022, Debug x64, no SSL, Static, HTTP only'
APPVEYOR_BUILD_WORKER_IMAGE: 'Visual Studio 2022' |
|
If this version runs green, I'll add it. AppVeyor does not look cooperative. |
|
I believe we should merge this as it is. |
bagder
approved these changes
Oct 3, 2023
vszakats
approved these changes
Oct 3, 2023
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this pull request
Nov 28, 2023
- 3s is too short for our CI, making this test fail occasionally - test usually experiences no delay run locally, so 30s wont hurt Closes curl#12013
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this pull request
Nov 28, 2023
Follow-up from 8a940fd / curl#12013 Closes curl#12017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.