Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSTARTTLS: Don't print response character in denied messages #1203
+2
−2
Conversation
Both IMAP and POP3 response characters are used internally, but when appended to the STARTTLS denial message likely could confuse the user.
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Jan 12, 2017
|
@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @yirkha to be potential reviewers. |
|
Yes, let's get rid of those! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jay commentedJan 12, 2017
Both IMAP and POP3 response characters are used internally, but when
appended to the STARTTLS denial message likely could confuse the user.
If nobody likes this there is still the problem if the response code is set -1 and that's printed as a character. At the very least I think we should do something like
(ISALPHA(resp) ? resp : ' ')so that we don't print weird symbols. SMTP doesn't have this problem because libcurl is using its numeric response codes, so I've already fixed that separately in 4e6f483