lib: fix gcc warning in printf call#12082
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
jay
reviewed
Oct 11, 2023
Seen with gcc 13.2.0 on Debian: https://github.com/curl/curl-for-win/actions/runs/6476161689/job/17584426483#step:3:11104 Ref: curl#10284 Co-authored-by: Jay Satiro Closes curl#12082
jay
approved these changes
Oct 11, 2023
Member
There was a problem hiding this comment.
Since the warning text is not in this one I would add a brief explanation of it or the action taken, example
lib: fix gcc warning
- Do not pass NULL to printf %s.
...
The problem with the warnings in some cases like this one is they are confusing and take extra cognitive processing so that's why I was suggesting a summary of sorts so it's easy to see what the warning is actually for or what is being fixed. I agree it is good to keep the actual warning in the PR so we have a record of what it actually said. The CI links are all ephemeral so in the commit message they are only good for so long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not pass NULL to printf %s.
Seen with gcc 13.2.0 on Debian:
Ref: https://github.com/curl/curl-for-win/actions/runs/6476161689/job/17584426483#step:3:11104
Ref: #10284
Co-authored-by: Jay Satiro
Closes #12082