-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP/2, header conversion tightening #12097
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
icing
commented
Oct 12, 2023
- fold the code to convert dynhds to the nghttp2 structs into a dynhds internal method
- saves code duplication
- pacifies compiler analyzers
Warnings reduced to a single block after the patch. Before: After:
|
That's also true of msh3 and quiche. I think the pattern could be eliminated from all of vquic. Otherwise it looks fine. |
bagder
reviewed
Oct 13, 2023
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Oct 16, 2023
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Oct 17, 2023
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Oct 18, 2023
- fold the code to convert dynhds to the nghttp2 structs into a dynhds internal method - saves code duplication - pacifies compiler analyzers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.