hostip: show the list of IPs when resolving is done#12145
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Member
Author
|
excellent, thanks! |
Member
|
It would be better if it showed hostname but there's no easy way to determine which is the hostname passed to resolve so I propose add it in Curl_dns_entry. see most recent commit. I also added the 'none' to clarify if none were found: |
Member
Author
That byte is already in the struct by default. Now you add one extra byte... |
jay
force-pushed
the
bagder/hostip-list-IPs
branch
from
44a269e to
4e9dc30
Compare
Member
|
oops forgot about the hostname[1]. reset to 'fixup avoid warning with strcpy'. i saw some malloc crashes and i figured that was the problem. |
Member
Author
|
it is the strcpy that is wrong because the host name can be longer than hostlen... |
Getting 'curl.se' today then gets this verbose output which might help debugging connectivity related matters. * Host curl.se:80 was resolved. * IPv6: 2a04:4e42::347, 2a04:4e42:200::347, 2a04:4e42:400::347, 2a04:4e42:600::347, 2a04:4e42:800::347, 2a04:4e42:a00::347, 2a04:4e42:c00::347, 2a04:4e42:e00::347 * IPv4: 151.101.193.91, 151.101.1.91, 151.101.65.91, 151.101.129.91 Co-authored-by: Jay Satiro Closes #12145
bagder
force-pushed
the
bagder/hostip-list-IPs
branch
from
94783c9 to
16d5325
Compare
fffaraz
reviewed
Oct 25, 2023
| #ifdef CURLRES_IPV6 | ||
| (a->ai_family == PF_INET6) || | ||
| #endif | ||
| (a->ai_family == PF_INET)) { |
Contributor
There was a problem hiding this comment.
Error when compiling without IPv6 support:
error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
note: remove extraneous parentheses around the comparison to silence this warning
Member
There was a problem hiding this comment.
Thanks but we don't use that warning.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 27, 2023
Seen with LLVM 17.
```
hostip.c:1336:22: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
1336 | (a->ai_family == PF_INET)) {
| ~~~~~~~~~~~~~^~~~~~~~~~
hostip.c:1336:22: note: remove extraneous parentheses around the comparison to silence this warning
1336 | (a->ai_family == PF_INET)) {
| ~ ^ ~
hostip.c:1336:22: note: use '=' to turn this equality comparison into an assignment
1336 | (a->ai_family == PF_INET)) {
| ^~
| =
1 warning generated.
```
Follow-up to b651aba curl#12145
Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Oct 27, 2023
Seen with LLVM 17.
```
hostip.c:1336:22: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
1336 | (a->ai_family == PF_INET)) {
| ~~~~~~~~~~~~~^~~~~~~~~~
hostip.c:1336:22: note: remove extraneous parentheses around the comparison to silence this warning
1336 | (a->ai_family == PF_INET)) {
| ~ ^ ~
hostip.c:1336:22: note: use '=' to turn this equality comparison into an assignment
1336 | (a->ai_family == PF_INET)) {
| ^~
| =
1 warning generated.
```
Follow-up to b651aba #12145
Reviewed-by: Daniel Stenberg
Closes #12215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting 'curl.se' today then gets this verbose output which might help debugging connectivity related matters.