quiche: use a quiche_conn_peer_transport_params() #12180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
junhochoi
commented
Oct 22, 2023
junhochoi
commented
- There was quiche API changes separating quiche_stats and quiche_transport_params(). Use a new API.
- Bump quiche version to master to test it in CI.
junhochoi
force-pushed
the
junhochoi/quiche_use_transport_param_api
branch
3 times, most recently
from
6685abc
to
0fd756e
Compare
Closed
|
Just published quiche 0.19 (sorry for the delay, was waiting for some other changes to land first). |
|
@junhochoi could you update the quiche version to 0.19.0 in your PR? I think then everything should be fine. |
junhochoi
force-pushed
the
junhochoi/quiche_use_transport_param_api
branch
from
0fd756e
to
947fe68
Compare
In recent quiche, transport parameter API is separated with quiche_conn_peer_transport_params(). (cloudflare/quiche#1575) It breaks with bulding with latest(post 0.18.0) quiche.
junhochoi
force-pushed
the
junhochoi/quiche_use_transport_param_api
branch
from
947fe68
to
508f513
Compare
|
Bumped! |
bagder
approved these changes
Nov 11, 2023
bagder
pushed a commit
that referenced
this pull request
Nov 11, 2023
|
Thanks! |
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this pull request
Nov 28, 2023
In recent quiche, transport parameter API is separated with quiche_conn_peer_transport_params(). (cloudflare/quiche#1575) It breaks with bulding with latest(post 0.18.0) quiche. Closes curl#12180
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.