Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quiche: use a quiche_conn_peer_transport_params() #12180

Conversation

junhochoi
Copy link
Contributor

  • There was quiche API changes separating quiche_stats and quiche_transport_params(). Use a new API.
  • Bump quiche version to master to test it in CI.

@github-actions github-actions bot added the CI Continuous Integration label Oct 22, 2023
@junhochoi junhochoi force-pushed the junhochoi/quiche_use_transport_param_api branch 3 times, most recently from 6685abc to 0fd756e Compare October 22, 2023 11:20
@junhochoi
Copy link
Contributor Author

PTAL @ghedo @LPardue probably a good time to make a new release?

@bagder
Copy link
Member

bagder commented Oct 22, 2023

PTAL @ghedo @LPardue probably a good time to make a new release?

Seconded. I too have been waiting for one to land exactly this fix...

@bagder bagder added the HTTP/3 h3 or quic related label Oct 22, 2023
@bagder bagder mentioned this pull request Nov 3, 2023
@ghedo
Copy link
Contributor

ghedo commented Nov 10, 2023

Just published quiche 0.19 (sorry for the delay, was waiting for some other changes to land first).

@icing
Copy link
Contributor

icing commented Nov 10, 2023

@junhochoi could you update the quiche version to 0.19.0 in your PR? I think then everything should be fine.

@junhochoi junhochoi force-pushed the junhochoi/quiche_use_transport_param_api branch from 0fd756e to 947fe68 Compare November 10, 2023 22:44
In recent quiche, transport parameter API is separated
with quiche_conn_peer_transport_params().
(cloudflare/quiche#1575)
It breaks with bulding with latest(post 0.18.0) quiche.
@junhochoi junhochoi force-pushed the junhochoi/quiche_use_transport_param_api branch from 947fe68 to 508f513 Compare November 10, 2023 22:49
@junhochoi
Copy link
Contributor Author

Bumped!

@bagder bagder closed this in 93c7943 Nov 11, 2023
bagder pushed a commit that referenced this pull request Nov 11, 2023
@bagder
Copy link
Member

bagder commented Nov 11, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration hacktoberfest-accepted HTTP/3 h3 or quic related
Development

Successfully merging this pull request may close these issues.

None yet

4 participants