New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: preserve the modification date when copying the prebuilt man page #12199
Conversation
Fix this autobuild problem: https://curl.se/dev/log.cgi?id=20231025023847-2167007#prob3 CC @dfandrich |
-p is nonstandard, so it won't be completely portable. The main platforms
support it, but there's no way to override the option on platforms where it
doesn't work, which isn't ideal. But, I'm not sure if this is anymore more than
a theoretical concern in this day and age.
|
A different bugfix that uses the
|
I would expect touch -r have the same problems or perhaps worse than cp -p ... |
cp -p and touch -r are POSIX though; install -p isn't (that I can find).
|
I think the touch proposal three comments up has the best chance of working. We're not using touch anywhere else in the build system yet but it's a standard POSIX command so it should be available everywhere. |
The previously built man page "curl.1" must be copied with the original modification date, otherwise the man page is never updated. This fixes a bug that has been introduced with commit 2568441.
Ok, I have updated the pull request, now it uses |
|
It was using cp -p until commit 2568441 which switched to install and
introduced the problem this PR fixes. The switch away from cp -p was done
because cp errors out when it can't change the UID and GID, but we don't care
about those.
|
@bagder OK to merge this? |
The previously built man page "curl.1" must be copied with the original modification date, otherwise the man page is never updated. This fixes a bug that has been introduced with commit 2568441. Reviewed-by: Dan Fandrich Reviewed-by: Daniel Stenberg Closes curl#12199
The previously built man page "curl.1" must be copied with the original modification date, otherwise the man page is never updated.
This fixes a bug that has been introduced with commit 2568441.