Skip to content

hostip: silence compiler warning -Wparentheses-equality#12215

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:hostip-warning
Closed

hostip: silence compiler warning -Wparentheses-equality#12215
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:hostip-warning

Conversation

@vszakats

@vszakats vszakats commented Oct 27, 2023

Copy link
Copy Markdown
Member

Seen with LLVM 17.

hostip.c:1336:22: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
 1336 |        (a->ai_family == PF_INET)) {
      |         ~~~~~~~~~~~~~^~~~~~~~~~
hostip.c:1336:22: note: remove extraneous parentheses around the comparison to silence this warning
 1336 |        (a->ai_family == PF_INET)) {
      |        ~             ^         ~
hostip.c:1336:22: note: use '=' to turn this equality comparison into an assignment
 1336 |        (a->ai_family == PF_INET)) {
      |                      ^~
      |                      =
1 warning generated.

Follow-up to b651aba #12145

Closes #12215

Seen with LLVM 17.

```
hostip.c:1336:22: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
 1336 |        (a->ai_family == PF_INET)) {
      |         ~~~~~~~~~~~~~^~~~~~~~~~
hostip.c:1336:22: note: remove extraneous parentheses around the comparison to silence this warning
 1336 |        (a->ai_family == PF_INET)) {
      |        ~             ^         ~
hostip.c:1336:22: note: use '=' to turn this equality comparison into an assignment
 1336 |        (a->ai_family == PF_INET)) {
      |                      ^~
      |                      =
1 warning generated.
```

Follow-up to b651aba curl#12145

Closes #xxxxx
@github-actions github-actions Bot added the name lookup DNS and related tech label Oct 27, 2023
@jay

jay commented Oct 28, 2023

Copy link
Copy Markdown
Member

nothing against this change but imo extraneous parentheses warning is too strict a warning to be useful and i don't think we should have to adjust code that way. extra parentheses are subjective. they may or may not be helpful. for example they are sometimes helpful for readability or maybe macros use it so you end up with extra. i thought we weren't using the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

name lookup DNS and related tech

Development

Successfully merging this pull request may close these issues.

3 participants