curl_setup: disallow Windows IPv6 builds missing getaddrinfo#12221
Closed
jay wants to merge 1 commit into
Closed
Conversation
- On Windows if IPv6 is enabled but getaddrinfo is missing then #error the build. curl can be built with IPv6 support (ENABLE_IPV6) but without the ability to resolve hosts to IPv6 addresses (HAVE_GETADDRINFO). On Windows this is highly unlikely and should be considered a bad build configuration. Such a bad configuration has already given us a bug that was hard to diagnose. See curl#12134 and curl#12136 for discussion. Ref: curl#12134 Ref: curl#12136 Closes #xxxx
MarcelRaad
approved these changes
Oct 28, 2023
MarcelRaad
left a comment
MarcelRaad
left a comment
Member
There was a problem hiding this comment.
Right, both IPv6 and getaddrinfo were added in Windows XP. Makes sense to me!
vszakats
approved these changes
Oct 28, 2023
bagder
approved these changes
Oct 28, 2023
bagder
left a comment
bagder
left a comment
Member
There was a problem hiding this comment.
Sensible lesson to draw from this past week
Member
|
Related, we might also consider:
|
1 task
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 28, 2023
After this patch we assume availability of `getaddrinfo` and `freeaddrinfo`, first introduced in Windows XP. TODO: assume these also in autotools. Ref: curl#12221 (comment) Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Oct 30, 2023
After this patch we assume availability of `getaddrinfo` and `freeaddrinfo`, first introduced in Windows XP. Meaning curl now requires building for Windows XP as a minimum. TODO: assume these also in autotools. Ref: #12221 (comment) Closes #12225
vszakats
added a commit
that referenced
this pull request
Dec 16, 2023
And DLL-support with it. This leaves `Makefile.mk` for MS-DOS and Amiga. We recommend CMake instead. With unity mode it's much faster, and about the same without. Ref: #12221 (comment) Reviewed-by: Daniel Stenberg Closes #12224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl can be built with IPv6 support (ENABLE_IPV6) but without the ability to resolve hosts to IPv6 addresses (HAVE_GETADDRINFO). On Windows this is highly unlikely and should be considered a bad build configuration.
Such a bad configuration has already given us a bug that was hard to diagnose. See #12134 and #12136 for discussion.
Ref: #12134
Ref: #12136
Closes #xxxx