Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: fix support for mbedtls. #1223

Closed
wants to merge 1 commit into from
Closed

vtls: fix support for mbedtls. #1223

wants to merge 1 commit into from

Conversation

@p1ng0o
Copy link
Contributor

@p1ng0o p1ng0o commented Jan 19, 2017

When using multi, mbedtls handshake is in non blocking mode.
vtls must set wait for read/write flags for the socket.

@bagder bagder added the TLS label Jan 19, 2017
defined(USE_DARWINSSL) || defined(USE_NSS)
/* This function is for OpenSSL, GnuTLS, darwinssl, and schannel only. */
defined(USE_DARWINSSL) || defined(USE_NSS) || defined(USE_MBEDTLS)
/* This function is for OpenSSL, GnuTLS, darwinssl, mbedtls, and schannel only. */
Copy link
Member

@bagder bagder Jan 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checksrc failure

./vtls/vtls.c:489:83: warning: Longer than 79 columns (LONGLINE)

Loading

When using multi, mbedtls handshake is in non blocking mode.
vtls must set wait for read/write flags for the socket.
@p1ng0o
Copy link
Contributor Author

@p1ng0o p1ng0o commented Jan 20, 2017

thx, fixed

Loading

@bagder bagder closed this in 06b1197 Jan 20, 2017
@bagder
Copy link
Member

@bagder bagder commented Jan 20, 2017

Thanks!

Loading

peterpih pushed a commit to railsnewbie257/curl that referenced this issue Jan 24, 2017
When using multi, mbedtls handshake is in non blocking mode.  vtls must
set wait for read/write flags for the socket.

Closes curl#1223
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants