vtls: fix support for mbedtls. #1223

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@p1ng0o
Contributor
p1ng0o commented Jan 19, 2017

When using multi, mbedtls handshake is in non blocking mode.
vtls must set wait for read/write flags for the socket.

@bagder bagder added the SSL/TLS label Jan 19, 2017
lib/vtls/vtls.c
- defined(USE_DARWINSSL) || defined(USE_NSS)
-/* This function is for OpenSSL, GnuTLS, darwinssl, and schannel only. */
+ defined(USE_DARWINSSL) || defined(USE_NSS) || defined(USE_MBEDTLS)
+/* This function is for OpenSSL, GnuTLS, darwinssl, mbedtls, and schannel only. */
@bagder
bagder Jan 19, 2017 Member

checksrc failure

./vtls/vtls.c:489:83: warning: Longer than 79 columns (LONGLINE)
@p1ng0o p1ng0o vtls: fix mbedtls multi non blocking handshake.
When using multi, mbedtls handshake is in non blocking mode.
vtls must set wait for read/write flags for the socket.
b993d2c
@p1ng0o
Contributor
p1ng0o commented Jan 20, 2017

thx, fixed

@bagder bagder added a commit that closed this pull request Jan 20, 2017
@p1ng0o @bagder p1ng0o + bagder vtls: fix mbedtls multi non blocking handshake.
When using multi, mbedtls handshake is in non blocking mode.  vtls must
set wait for read/write flags for the socket.

Closes #1223
06b1197
@bagder bagder closed this in 06b1197 Jan 20, 2017
@bagder
Member
bagder commented Jan 20, 2017

Thanks!

@jkralik jkralik added a commit to jkralik/curl that referenced this pull request Jan 23, 2017
@p1ng0o @jkralik p1ng0o + jkralik vtls: fix mbedtls multi non blocking handshake.
When using multi, mbedtls handshake is in non blocking mode.  vtls must
set wait for read/write flags for the socket.

Closes #1223
b11ad93
@peterpih peterpih pushed a commit to railsnewbie257/curl that referenced this pull request Jan 24, 2017
@p1ng0o @railsnewbie257 p1ng0o + railsnewbie257 vtls: fix mbedtls multi non blocking handshake.
When using multi, mbedtls handshake is in non blocking mode.  vtls must
set wait for read/write flags for the socket.

Closes #1223
ad4a1ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment