Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtls: fix support for mbedtls. #1223

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@p1ng0o
Copy link
Contributor

commented Jan 19, 2017

When using multi, mbedtls handshake is in non blocking mode.
vtls must set wait for read/write flags for the socket.

@bagder bagder added the SSL/TLS label Jan 19, 2017

defined(USE_DARWINSSL) || defined(USE_NSS)
/* This function is for OpenSSL, GnuTLS, darwinssl, and schannel only. */
defined(USE_DARWINSSL) || defined(USE_NSS) || defined(USE_MBEDTLS)
/* This function is for OpenSSL, GnuTLS, darwinssl, mbedtls, and schannel only. */

This comment has been minimized.

Copy link
@bagder

bagder Jan 19, 2017

Member

checksrc failure

./vtls/vtls.c:489:83: warning: Longer than 79 columns (LONGLINE)
vtls: fix mbedtls multi non blocking handshake.
When using multi, mbedtls handshake is in non blocking mode.
vtls must set wait for read/write flags for the socket.

@p1ng0o p1ng0o force-pushed the p1ng0o:master branch from f16cf32 to b993d2c Jan 20, 2017

@p1ng0o

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2017

thx, fixed

@bagder bagder closed this in 06b1197 Jan 20, 2017

@bagder

This comment has been minimized.

Copy link
Member

commented Jan 20, 2017

Thanks!

jkralik pushed a commit to jkralik/curl that referenced this pull request Jan 23, 2017

vtls: fix mbedtls multi non blocking handshake.
When using multi, mbedtls handshake is in non blocking mode.  vtls must
set wait for read/write flags for the socket.

Closes curl#1223

peterpih pushed a commit to railsnewbie257/curl that referenced this pull request Jan 24, 2017

vtls: fix mbedtls multi non blocking handshake.
When using multi, mbedtls handshake is in non blocking mode.  vtls must
set wait for read/write flags for the socket.

Closes curl#1223

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.