Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl.h: add CURLE_TOO_LARGE #12269

Closed
wants to merge 1 commit into from
Closed

curl.h: add CURLE_TOO_LARGE #12269

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Nov 4, 2023

This adds a new error code that can be used when an internal field grows too large, like when a dynbuf reaches its maximum. Previously it would return CURLE_OUT_OF_MEMORY for this, which is highly misleading.

Ref: #12268

@dfandrich
Copy link
Contributor

dfandrich commented Nov 4, 2023 via email

@bagder
Copy link
Member Author

bagder commented Nov 4, 2023 •
edited
Loading

Would CURLE_BAD_FUNCTION_ARGUMENT work instead? Or is that too oblique?

I think that error code should be used when there is a more direct and immediate correlation between an input the result.

@github-actions github-actions bot added the tests label Nov 4, 2023
@jay
Copy link
Member

jay commented Nov 5, 2023

hyper ci job test 1154 is returning CURLE_OUT_OF_MEMORY instead of CURLE_TOO_LARGE

@bagder bagder added the feature-window A merge of this requires an open feature window label Nov 10, 2023
bagder added a commit that referenced this pull request Nov 20, 2023
@bagder
curl.h: add CURLE_TOO_LARGE
4a42a1e 
This adds a new error code that can be used when an internal field grows
too large, like when a dynbuf reaches its maximum. Previously it would
return CURLE_OUT_OF_MEMORY for this, which is highly misleading.

Ref: #12268
Closes #12269
@bagder bagder marked this pull request as ready for review November 20, 2023 10:03
@bagder bagder added needs-votes Pull-request in need of thumbs-ups to make progress and removed needs-votes Pull-request in need of thumbs-ups to make progress labels Nov 28, 2023
bagder added a commit that referenced this pull request Nov 28, 2023
@bagder
curl.h: add CURLE_TOO_LARGE
fac5c61 
This adds a new error code that can be used when an internal field grows
too large, like when a dynbuf reaches its maximum. Previously it would
return CURLE_OUT_OF_MEMORY for this, which is highly misleading.

Ref: #12268
Closes #12269
bagder added a commit that referenced this pull request Nov 30, 2023
@bagder
curl.h: add CURLE_TOO_LARGE
ef39a7d 
This adds a new error code that can be used when an internal field grows
too large, like when a dynbuf reaches its maximum. Previously it would
return CURLE_OUT_OF_MEMORY for this, which is highly misleading.

Ref: #12268
Closes #12269
@bagder
curl.h: add CURLE_TOO_LARGE
26888e3 
This adds a new error code that can be used when an internal field grows
too large, like when a dynbuf reaches its maximum. Previously it would
return CURLE_OUT_OF_MEMORY for this, which is highly misleading.

Ref: #12268
Closes #12269
@bagder bagder closed this in f58e493 Dec 18, 2023
@bagder bagder deleted the bagder/CURLE_TOO_LARGE branch December 18, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature-window A merge of this requires an open feature window libcurl API tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bagder @dfandrich @jay