mbedtls: ramdom can use havege if enabled. #1227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1ng0o
force-pushed
the
master
branch
2 times, most recently
from
b957d5e
to
cb34e4c
Compare
bagder
reviewed
Jan 26, 2017
| mbedtls_strerror(ret, errorbuf, sizeof(errorbuf)); | ||
| #endif /* MBEDTLS_ERROR_C */ | ||
| failf(data, "Failed - mbedTLS: ctr_drbg_seed returned (-0x%04X) %s\n", | ||
| -ret, errorbuf); |
There was a problem hiding this comment.
shouldn't it also return an error here?
You tell me! Should it be saved? When the 'data' pointer is provided, it could be stored in that struct. |
bagder
reviewed
Jan 26, 2017
| @@ -729,6 +729,56 @@ size_t Curl_mbedtls_version(char *buffer, size_t size) | |||
| (version>>16)&0xff, (version>>8)&0xff); | |||
| } | |||
|
|
|||
| int Curl_mbedtls_random(struct Curl_easy *data, unsigned char *entropy, | |||
| size_t length) | |||
There was a problem hiding this comment.
I think this is better declared to return CURLcode rather than int.
|
The question was, do I privilege cpu time (struct on data), or mem (struct on cstack). |
|
Yeah, this function is not used a lot nor in any high performance situation so I think that's totally fine. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't succeed to write a "proper" CTR-DRBG random generator. So let's begin with havege 👍
Anyway, should I save mbedtls_havege_state somewhere ?