Skip to content

Windows VC14.20 project missing#12282

Closed
dsv123 wants to merge 2 commits into
curl:masterfrom
dsv123:vc142
Closed

Windows VC14.20 project missing#12282
dsv123 wants to merge 2 commits into
curl:masterfrom
dsv123:vc142

Conversation

@dsv123

@dsv123 dsv123 commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Windows projects included VC14, VC14.10, VC14.30 but not VC14.20.
OpenSSL and WolfSSL bat scripts mention VC14.20 so I don't suspect an underlying problem with this platform toolset.

Updated the templates to produce a VC14.20 project. Project opens (and builds) in Visual Studio 2019 as expected.
The VC14.30 solution contained text "Visual Studio 15" instead of "Visual Studio 17", updated.

Windows projects included VC14, VC14.10, VC14.30 but not VC14.20.
OpenSSL and Wolf SSL scripts mention VC14.20 so I don't see a reason why this is missing.
Updated the templates to produce a VC14.20 project.
Project opens in Visual Studio 2019 as expected.
@vszakats vszakats added build Windows Windows-specific labels Nov 6, 2023
@bagder

bagder commented Nov 6, 2023

Copy link
Copy Markdown
Member

Since Visual Studio 2012 and older all seem to be end of life now, I think we can drop them from the release archives. Based on this: https://learn.microsoft.com/en-us/visualstudio/releases/2019/servicing-vs2019

II hadn't saved this file after updating it on previous pull request.
This file was identical to that from VC14.30 Fixed version numbers.
@bagder bagder closed this in 2828709 Nov 7, 2023
@bagder

bagder commented Nov 7, 2023

Copy link
Copy Markdown
Member

Thanks!

@bagder bagder reopened this Nov 7, 2023
@bagder

bagder commented Nov 7, 2023

Copy link
Copy Markdown
Member

@dsv123 this does not add any code to Makefile.am in the style of 14_30 so I'm pretty sure this then does not create working 14.20 files in the tarballs. See:

curl/Makefile.am

Lines 600 to 622 in 2828709

echo "generating '$(VC14_30_LIBVCXPROJ)'"; \
awk -v proj_type=vcxproj \
-v lib_srcs="$$sorted_lib_srcs" \
-v lib_hdrs="$$sorted_lib_hdrs" \
-v lib_rc="$$win32_lib_rc" \
-v lib_vauth_srcs="$$sorted_lib_vauth_srcs" \
-v lib_vauth_hdrs="$$sorted_lib_vauth_hdrs" \
-v lib_vquic_srcs="$$sorted_lib_vquic_srcs" \
-v lib_vquic_hdrs="$$sorted_lib_vquic_hdrs" \
-v lib_vssh_srcs="$$sorted_lib_vssh_srcs" \
-v lib_vssh_hdrs="$$sorted_lib_vssh_hdrs" \
-v lib_vtls_srcs="$$sorted_lib_vtls_srcs" \
-v lib_vtls_hdrs="$$sorted_lib_vtls_hdrs" \
"$$awk_code" $(srcdir)/$(VC14_30_LIBTMPL) > $(VC14_30_LIBVCXPROJ) || { exit 1; }; \
\
echo "generating '$(VC14_30_SRCVCXPROJ)'"; \
awk -v proj_type=vcxproj \
-v src_srcs="$$sorted_src_srcs" \
-v src_hdrs="$$sorted_src_hdrs" \
-v src_rc="$$win32_src_rc" \
-v src_x_srcs="$$sorted_src_x_srcs" \
-v src_x_hdrs="$$sorted_src_x_hdrs" \
"$$awk_code" $(srcdir)/$(VC14_30_SRCTMPL) > $(VC14_30_SRCVCXPROJ) || { exit 1; };)

@bagder

bagder commented Nov 7, 2023

Copy link
Copy Markdown
Member

I realized this when I made #12288 just now

@bagder

bagder commented Nov 7, 2023

Copy link
Copy Markdown
Member

Anyway, that should be fixed in a separate PR, just wanted to highlight this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Windows Windows-specific

Development

Successfully merging this pull request may close these issues.

3 participants