allow longer http methods for service-specific custom methods #12311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this a good idea. The longest registered method UPDATEREDIRECTREF is 17 characters long. By custom methods do you mean methods not registered? |
|
Thank you for the additional motivation to change the current limitation! Our custom methods won't be registered because they are used only in our internal services. The max length of our methods is 18 bytes, so I think 23 is large enough for those who use custom, unregistered methods. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, team! Looks like #10720 has accidentally added a new limitation to the length of HTTP methods to
11, which affects our internal use of curl(1).This PR doubles the limitation, which is large enough for our usage. Can you take a look at it?