Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool: support bold headers in Windows #12321

Closed
wants to merge 2 commits into from
Closed

tool: support bold headers in Windows #12321

wants to merge 2 commits into from

Conversation

jay
Copy link
Member

@jay jay commented Nov 14, 2023

  • If virtual terminal processing is enabled in Windows then use ANSI escape codes Esc[1m and Esc[22m to turn bold on and off.

Suggested-by: Gisle Vanem

Ref: #11770

Closes #xxxx

prompt

/cc @gvanem @dfandrich

@jay
tool: support bold headers in Windows
3798db2 
- If virtual terminal processing is enabled in Windows then use ANSI
  escape codes Esc[1m and Esc[22m to turn bold on and off.

Suggested-by: Gisle Vanem

Ref: curl#11770

Closes #xxxx
bagder
bagder reviewed Nov 14, 2023
View reviewed changes
src/tool_doswin.c Outdated Show resolved Hide resolved
@bagder bagder added the Windows Windows-specific label Nov 14, 2023
@jay jay closed this in 8261800 Nov 16, 2023
@jay jay deleted the win32_bold_headers branch November 16, 2023 09:00
@gvanem
Copy link
Contributor

gvanem commented Nov 16, 2023 •
edited
Loading

What could be done for the link-text on Windows? AFAIK, it's possible with underlined text under VTS,
but I'm not sure that's the same as for Unix. How does a LINK <url> look and work under Unix? Click on it and it opens the
default browser?

@bagder
Copy link
Member

bagder commented Nov 16, 2023

How does a LINK look and work under Unix? Click on it and it opens the default browser?

Click on it and the "default app" for that link type opens it, yes. Presumably typically a browser.

@gvanem
Copy link
Contributor

gvanem commented Nov 16, 2023

Click on it and the "default app" for that link type opens it, yes.

That would be hard to accomplish on Windows I guess.

@DHowett
Copy link
Contributor

DHowett commented Dec 6, 2023

That would be hard to accomplish on Windows I guess.

With Windows Terminal, you can Ctrl-click URLs to open them in your default browser. 🙂

@bagder
Copy link
Member

bagder commented Dec 6, 2023

With Windows Terminal, you can Ctrl-click URLs to open them in your default browser. 🙂

Yes, but with some of the other-systems terminals, we can also "mark up" relative URLs used in the headers and spell out the full URL for when someone clicks on them. Ie use more meta-data than what is visible on screen.

@DHowett
Copy link
Contributor

DHowett commented Dec 6, 2023

If you end up using OSC 8 (the standard for hyperlinks in terminals) that will work on Windows as well!

@bagder
Copy link
Member

bagder commented Dec 6, 2023

Aha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanem gvanem gvanem left review comments

@bagder bagder bagder left review comments

Assignees
No one assigned
Labels
cmdline tool Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jay @gvanem @bagder @DHowett